Skip to content

ArchiSteamFarm.ui: use buildNpmPackage#230560

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
legendofmiracles:upddate-nodjs-asf
May 9, 2023
Merged

ArchiSteamFarm.ui: use buildNpmPackage#230560
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
legendofmiracles:upddate-nodjs-asf

Conversation

@legendofmiracles
Copy link
Contributor

Description of changes

related to #229910

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 7, 2023
@legendofmiracles
Copy link
Contributor Author

I'm testing it right now, and it isn't quite working yet. Give me a minute.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 8, 2023
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 8, 2023
@SuperSandro2000
Copy link
Member

Tested and the output is identical, so nothing changed about it's working.

@SuperSandro2000 SuperSandro2000 merged commit d199137 into NixOS:master May 9, 2023
@SuperSandro2000
Copy link
Member

we forgot to update the update script...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants