Skip to content

Bump nvidia-modelopt>=0.44.0 - #4803

Merged
kevalmorabia97 merged 1 commit into
NVIDIA:mainfrom
kevalmorabia97:kmorabia/bump-modelopt-0.44
May 14, 2026
Merged

Bump nvidia-modelopt>=0.44.0#4803
kevalmorabia97 merged 1 commit into
NVIDIA:mainfrom
kevalmorabia97:kmorabia/bump-modelopt-0.44

Conversation

@kevalmorabia97

Copy link
Copy Markdown
Contributor

What does this PR do ?

Bump to nvidia-modelopt>=0.44.0 released yesterday

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft May 14, 2026 18:14
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented May 14, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@kevalmorabia97

Copy link
Copy Markdown
Contributor Author

/ok to test 446f241

@kevalmorabia97
kevalmorabia97 marked this pull request as ready for review May 14, 2026 18:16
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team May 14, 2026 18:16
@kevalmorabia97
kevalmorabia97 requested a review from a team May 14, 2026 18:16
@kevalmorabia97
kevalmorabia97 requested review from a team and removed request for a team May 14, 2026 18:17
@kevalmorabia97
kevalmorabia97 enabled auto-merge May 14, 2026 18:25
@kevalmorabia97
kevalmorabia97 added this pull request to the merge queue May 14, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25882308607

Merged via the queue into NVIDIA:main with commit 98031e1 May 14, 2026
79 of 83 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/bump-modelopt-0.44 branch May 14, 2026 22:18
SpencerGarnets added a commit to ai-blaise/Megatron-LM that referenced this pull request May 16, 2026
Upstream main tip: f92a207

Pulled commits:

- f92a207 Update copy-pr-bot.yaml [skip ci]

- b3b6719 ci: tolerate git-gc race in /home/runner chown after checkout (NVIDIA#4808)

- 9b4074b Inference: Optimize Prefill Engine Steps for Nemotron (NVIDIA#4764)

- a53107c chore: Update nightly tests golden values (NVIDIA#4805)

- e9a0930 ci: Update workflow to use same commit for build+test (NVIDIA#4787)

- 266562f Update owners (NVIDIA#4794)

- 98031e1 Bump nvidia-modelopt>=0.44.0 (NVIDIA#4803)

- d167123 fix tokenizers in respect to newer transformers (NVIDIA#4608)

- dbfc96b Use Protocols to type-check linear_proj submodules of Attention (NVIDIA#3434)

Conflict resolutions:

- .github/CODEOWNERS: --theirs (upstream granular team mapping)

- megatron/core/transformer/attention.py: composed -- kept ours StreamBP imports, dropped dead ModuleSpec/build_module import (replaced by Protocol in NVIDIA#3434), kept ours attn_proj_manager pattern because our fine_grained_activation_offload.py keeps group_offload API while upstream split to static group_commit, but adopted apply_module(self.linear_proj) wrapper from NVIDIA#3434

- megatron/core/transformer/multi_latent_attention.py: same apply_module+attn_proj_manager composition; took ours ChunkRange parameter for StreamBP plus upstream BaseInferenceContext type annotation

- pyproject.toml: bumped modelopt >=0.44 (upstream); kept transformer-engine[pytorch,core_cu13]>=2.9.0a0,<2.12.0 pin (custom for CUDA 13 / SM100)

- uv.lock: --ours; modelopt bump is non-breaking. uv lock regenerate blocked by stale /home/sjpat/wheelhouse torchcomms path (pre-existing).

Gates:

- git diff --check: clean

- conflict markers: none

- py_compile (15 changed .py files): OK

- attention.py + multi_latent_attention.py import OK

- indexcache: 27/28 pass (same single GPU-env failure as pre-merge base)

- transformer gdn/mtp/moe suite: 53 failed / 7 passed / 55 skipped / 5 errors -- identical to base (all failures are cudaErrorDevicesUnavailable from sglang occupying all H200s)

- 2-rank torchrun smoke: blocked (no free GPUs)

Custom preserved: StreamBP (megatron/core/transformer/streambp.py + tests/unit_tests/transformer/test_streambp.py + tools/streambp_prod_verify.py), IndexCache config + NVFP4 indexer, HISA topk1024 backward, emerging_optimizers v0.2.0 pin, mHC/MTP/MoE composition.
Victarry pushed a commit to yanring/Megatron-LM that referenced this pull request May 18, 2026
* origin/main: (138 commits)
  Refactor CUDA graph API: decompose cuda_graph_scope into full_iteration impl, inference scope, and per-layer capture modules (NVIDIA#4292)
  Add high-priority A2A stream and HybridEP preprocessing SMs (NVIDIA#4694)
  add is_torch_min_version in fsdp src (NVIDIA#4812)
  [Main][feat] Support A2A Overlap for Megatron-FSDP (NVIDIA#3797)
  Reorder mtp_post_process after attention backward in 1F1B schedule plan (NVIDIA#4695)
  [fix] Use MSC for checking checkpoint existence (NVIDIA#4251)
  Combine GEMM + SwiGLU fused MLP PRs (3890, 4071, 4095, 4219, 4311, 4324) → main (NVIDIA#4636)
  Strengthen test_checkpoint to verify distributed checkpoint behavior (NVIDIA#4711)
  Disable MSC by default; opt in via --enable-msc (NVIDIA#4629)
  additional tests for nvrx (NVIDIA#4522)
  Update copy-pr-bot.yaml [skip ci]
  ci: tolerate git-gc race in /home/runner chown after checkout (NVIDIA#4808)
  Inference: Optimize Prefill Engine Steps for Nemotron (NVIDIA#4764)
  chore: Update nightly tests golden values (NVIDIA#4805)
  ci: Update workflow to use same commit for building docker image and running tests (NVIDIA#4787)
  Update owners (NVIDIA#4794)
  Bump nvidia-modelopt>=0.44.0 (NVIDIA#4803)
  fix tokenizers in respect to newer transformers (NVIDIA#4608)
  Use Protocols to type-check linear_proj submodules of Attention (NVIDIA#3434)
  Fix recompute checkpointing + training CGs (NVIDIA#3919)
  ...

# Conflicts:
#	megatron/core/transformer/moe/moe_utils.py
janEbert pushed a commit to janEbert/Megatron-LM that referenced this pull request Jun 2, 2026
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants