chore: Update nightly tests golden values - #4805
Merged
Merged
Conversation
Contributor
Author
|
/ok to test 7b3a0cc |
chtruong814
approved these changes
May 14, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25890482190 |
SpencerGarnets
added a commit
to ai-blaise/Megatron-LM
that referenced
this pull request
May 16, 2026
Upstream main tip: f92a207 Pulled commits: - f92a207 Update copy-pr-bot.yaml [skip ci] - b3b6719 ci: tolerate git-gc race in /home/runner chown after checkout (NVIDIA#4808) - 9b4074b Inference: Optimize Prefill Engine Steps for Nemotron (NVIDIA#4764) - a53107c chore: Update nightly tests golden values (NVIDIA#4805) - e9a0930 ci: Update workflow to use same commit for build+test (NVIDIA#4787) - 266562f Update owners (NVIDIA#4794) - 98031e1 Bump nvidia-modelopt>=0.44.0 (NVIDIA#4803) - d167123 fix tokenizers in respect to newer transformers (NVIDIA#4608) - dbfc96b Use Protocols to type-check linear_proj submodules of Attention (NVIDIA#3434) Conflict resolutions: - .github/CODEOWNERS: --theirs (upstream granular team mapping) - megatron/core/transformer/attention.py: composed -- kept ours StreamBP imports, dropped dead ModuleSpec/build_module import (replaced by Protocol in NVIDIA#3434), kept ours attn_proj_manager pattern because our fine_grained_activation_offload.py keeps group_offload API while upstream split to static group_commit, but adopted apply_module(self.linear_proj) wrapper from NVIDIA#3434 - megatron/core/transformer/multi_latent_attention.py: same apply_module+attn_proj_manager composition; took ours ChunkRange parameter for StreamBP plus upstream BaseInferenceContext type annotation - pyproject.toml: bumped modelopt >=0.44 (upstream); kept transformer-engine[pytorch,core_cu13]>=2.9.0a0,<2.12.0 pin (custom for CUDA 13 / SM100) - uv.lock: --ours; modelopt bump is non-breaking. uv lock regenerate blocked by stale /home/sjpat/wheelhouse torchcomms path (pre-existing). Gates: - git diff --check: clean - conflict markers: none - py_compile (15 changed .py files): OK - attention.py + multi_latent_attention.py import OK - indexcache: 27/28 pass (same single GPU-env failure as pre-merge base) - transformer gdn/mtp/moe suite: 53 failed / 7 passed / 55 skipped / 5 errors -- identical to base (all failures are cudaErrorDevicesUnavailable from sglang occupying all H200s) - 2-rank torchrun smoke: blocked (no free GPUs) Custom preserved: StreamBP (megatron/core/transformer/streambp.py + tests/unit_tests/transformer/test_streambp.py + tools/streambp_prod_verify.py), IndexCache config + NVFP4 indexer, HISA topk1024 backward, emerging_optimizers v0.2.0 pin, mHC/MTP/MoE composition.
Victarry
pushed a commit
to yanring/Megatron-LM
that referenced
this pull request
May 18, 2026
* origin/main: (138 commits) Refactor CUDA graph API: decompose cuda_graph_scope into full_iteration impl, inference scope, and per-layer capture modules (NVIDIA#4292) Add high-priority A2A stream and HybridEP preprocessing SMs (NVIDIA#4694) add is_torch_min_version in fsdp src (NVIDIA#4812) [Main][feat] Support A2A Overlap for Megatron-FSDP (NVIDIA#3797) Reorder mtp_post_process after attention backward in 1F1B schedule plan (NVIDIA#4695) [fix] Use MSC for checking checkpoint existence (NVIDIA#4251) Combine GEMM + SwiGLU fused MLP PRs (3890, 4071, 4095, 4219, 4311, 4324) → main (NVIDIA#4636) Strengthen test_checkpoint to verify distributed checkpoint behavior (NVIDIA#4711) Disable MSC by default; opt in via --enable-msc (NVIDIA#4629) additional tests for nvrx (NVIDIA#4522) Update copy-pr-bot.yaml [skip ci] ci: tolerate git-gc race in /home/runner chown after checkout (NVIDIA#4808) Inference: Optimize Prefill Engine Steps for Nemotron (NVIDIA#4764) chore: Update nightly tests golden values (NVIDIA#4805) ci: Update workflow to use same commit for building docker image and running tests (NVIDIA#4787) Update owners (NVIDIA#4794) Bump nvidia-modelopt>=0.44.0 (NVIDIA#4803) fix tokenizers in respect to newer transformers (NVIDIA#4608) Use Protocols to type-check linear_proj submodules of Attention (NVIDIA#3434) Fix recompute checkpointing + training CGs (NVIDIA#3919) ... # Conflicts: # megatron/core/transformer/moe/moe_utils.py
janEbert
pushed a commit
to janEbert/Megatron-LM
that referenced
this pull request
Jun 2, 2026
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
svcnvidia-nemo-ci
pushed a commit
to dimapihtar/Megatron-LM
that referenced
this pull request
Aug 4, 2026
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Update nightly test golden values. Needed as we updated pytorch and TE versions for the release.
Issue tracking
For PRs from open-source community contributors:
Linked issue:
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.