Skip to content

Strengthen test_checkpoint to verify distributed checkpoint behavior - #4711

Merged
ericharper merged 3 commits into
NVIDIA:mainfrom
lichenlu:fix/test-checkpoint-strengthen
May 16, 2026
Merged

Strengthen test_checkpoint to verify distributed checkpoint behavior#4711
ericharper merged 3 commits into
NVIDIA:mainfrom
lichenlu:fix/test-checkpoint-strengthen

Conversation

@lichenlu

@lichenlu lichenlu commented May 9, 2026

Copy link
Copy Markdown
Contributor

The test now properly initializes model parallel with explicit sizes, places tensors on CUDA, enables gradients, and asserts forward output correctness, input reshaping after distribute, and backward pass.

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot

copy-pr-bot Bot commented May 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft May 9, 2026 02:15
@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@lichenlu @peibli
Strengthen test_checkpoint to verify distributed checkpoint behavior
dad32ed 
The test now properly initializes model parallel with explicit sizes,
places tensors on CUDA, enables gradients, and asserts forward output
correctness, input reshaping after distribute, and backward pass.

Co-authored-by: peibli <lipeibao@126.com>
@lichenlu
lichenlu force-pushed the fix/test-checkpoint-strengthen branch from 26cda5a to dad32ed Compare May 9, 2026 02:19
@lichenlu
lichenlu marked this pull request as ready for review May 9, 2026 02:20
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team May 9, 2026 02:20
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label May 11, 2026
@dimapihtar
dimapihtar self-requested a review May 12, 2026 13:54
@dimapihtar dimapihtar added complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels May 12, 2026
dimapihtar
dimapihtar approved these changes May 12, 2026
View reviewed changes

@dimapihtar dimapihtar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dimapihtar

dimapihtar commented May 12, 2026

Copy link
Copy Markdown
Contributor

/ok to test 08dd72b

@svcnvidia-nemo-ci svcnvidia-nemo-ci added waiting-on-customer Waiting on the original author to respond waiting-on-maintainers Waiting on maintainers to respond and removed waiting-on-maintainers Waiting on maintainers to respond waiting-on-customer Waiting on the original author to respond labels May 12, 2026
@ericharper
ericharper added this pull request to the merge queue May 15, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented May 15, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25928474154

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented May 15, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25938098757

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented May 15, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25938125402

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented May 15, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25942161998

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented May 16, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25947850460

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented May 16, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25952777632

Merged via the queue into NVIDIA:main with commit 493e2be May 16, 2026
70 checks passed
@svcnvidia-nemo-ci svcnvidia-nemo-ci removed the waiting-on-maintainers Waiting on maintainers to respond label May 16, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci mentioned this pull request May 16, 2026
Closed
Victarry pushed a commit to yanring/Megatron-LM that referenced this pull request May 18, 2026
Dennis Liu
Merge remote-tracking branch 'origin/main' into pr3431-conflict-fix
fc1ec88 
* origin/main: (138 commits)
  Refactor CUDA graph API: decompose cuda_graph_scope into full_iteration impl, inference scope, and per-layer capture modules (NVIDIA#4292)
  Add high-priority A2A stream and HybridEP preprocessing SMs (NVIDIA#4694)
  add is_torch_min_version in fsdp src (NVIDIA#4812)
  [Main][feat] Support A2A Overlap for Megatron-FSDP (NVIDIA#3797)
  Reorder mtp_post_process after attention backward in 1F1B schedule plan (NVIDIA#4695)
  [fix] Use MSC for checking checkpoint existence (NVIDIA#4251)
  Combine GEMM + SwiGLU fused MLP PRs (3890, 4071, 4095, 4219, 4311, 4324) → main (NVIDIA#4636)
  Strengthen test_checkpoint to verify distributed checkpoint behavior (NVIDIA#4711)
  Disable MSC by default; opt in via --enable-msc (NVIDIA#4629)
  additional tests for nvrx (NVIDIA#4522)
  Update copy-pr-bot.yaml [skip ci]
  ci: tolerate git-gc race in /home/runner chown after checkout (NVIDIA#4808)
  Inference: Optimize Prefill Engine Steps for Nemotron (NVIDIA#4764)
  chore: Update nightly tests golden values (NVIDIA#4805)
  ci: Update workflow to use same commit for building docker image and running tests (NVIDIA#4787)
  Update owners (NVIDIA#4794)
  Bump nvidia-modelopt>=0.44.0 (NVIDIA#4803)
  fix tokenizers in respect to newer transformers (NVIDIA#4608)
  Use Protocols to type-check linear_proj submodules of Attention (NVIDIA#3434)
  Fix recompute checkpointing + training CGs (NVIDIA#3919)
  ...

# Conflicts:
#	megatron/core/transformer/moe/moe_utils.py
janEbert pushed a commit to janEbert/Megatron-LM that referenced this pull request Jun 2, 2026
@lichenlu @peibli
@dimapihtar @janEbert
Strengthen test_checkpoint to verify distributed checkpoint behavior (N…
b3aa51b 
…VIDIA#4711)

Co-authored-by: peibli <lipeibao@126.com>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
@lichenlu @peibli
@dimapihtar @yhgalaxy
Strengthen test_checkpoint to verify distributed checkpoint behavior (N…
a8cdeb2 
…VIDIA#4711)

Co-authored-by: peibli <lipeibao@126.com>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
@lichenlu @peibli
@dimapihtar Jon Barker
Strengthen test_checkpoint to verify distributed checkpoint behavior (N…
a97cd51 
…VIDIA#4711)

Co-authored-by: peibli <lipeibao@126.com>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
@lichenlu @peibli
@dimapihtar @terminator123
Strengthen test_checkpoint to verify distributed checkpoint behavior (N…
f2201c1 
…VIDIA#4711)

Co-authored-by: peibli <lipeibao@126.com>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
@lichenlu @peibli @dimapihtar
Strengthen test_checkpoint to verify distributed checkpoint behavior (N…
72acd7d 
…VIDIA#4711)

Co-authored-by: peibli <lipeibao@126.com>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimapihtar dimapihtar dimapihtar approved these changes

Assignees

No one assigned

Labels

community-request complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lichenlu @dimapihtar @svcnvidia-nemo-ci @ericharper @ko3n1g