Skip to content

ci: tolerate git-gc race in /home/runner chown after checkout - #4808

Merged
balasaajay merged 2 commits into
NVIDIA:mainfrom
balasaajay:fix-chown-issue
May 15, 2026
Merged

ci: tolerate git-gc race in /home/runner chown after checkout#4808
balasaajay merged 2 commits into
NVIDIA:mainfrom
balasaajay:fix-chown-issue

Conversation

@balasaajay

Copy link
Copy Markdown
Contributor

What does this PR do ?

Make the Change ownership of /home/runner/ step in .github/actions/action.yml tolerant of a known infra race that was causing spurious test failures with the signature FAILED (exit skipped).

After actions/checkout@v6 finishes, it sometimes leaves a background git gc --auto running. The next step in the composite action runs sudo chown -R $(whoami) /home/runner/. While chown walks .git/objects/pack/, git pack-objects renames/deletes its temporary .tmp-<pid>-pack-<hash>.idx / .rev files. chown exits 1 with
No such file or directory, and because the composite shell uses bash -e -o pipefail by default, the step fails.
Every subsequent step (Setup python, Install uv, Pull container, Run main script, …) is then auto-skipped, so the test never runs. The final Check result step reads MAIN_CONCLUSION=skipped and prints ❌ FAILED (exit code: skipped) — making it look like a test regression when really nothing was ever tested. This race is non-deterministic and hardware/timing-dependent. It has hit several PRs over the past weeks on randomly different test jobs, e.g.:

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

… `.git/objects/pack/.tmp-*` files, adding retry logic for improved reliability.
@copy-pr-bot

copy-pr-bot Bot commented May 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@balasaajay
balasaajay marked this pull request as ready for review May 14, 2026 21:08
@balasaajay
balasaajay requested a review from a team as a code owner May 14, 2026 21:08
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team May 14, 2026 21:09
@balasaajay

Copy link
Copy Markdown
Contributor Author

/ok to test https://github.com/NVIDIA/MegatronLM/commit/0266dc46046cda1ee4b708b85150d259ad70bf1b

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label May 14, 2026
@balasaajay

Copy link
Copy Markdown
Contributor Author

/ok to test 32f772b

@balasaajay

Copy link
Copy Markdown
Contributor Author

/ok to test https://github.com/NVIDIA/MegatronLM/commit/32f772bf5e5b51e022f4ff82651d4cd38ec85ba9

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25936585922

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25938099917

@balasaajay
balasaajay removed this pull request from the merge queue due to a manual request May 15, 2026
@balasaajay
balasaajay merged commit b3b6719 into NVIDIA:main May 15, 2026
191 of 195 checks passed
SpencerGarnets added a commit to ai-blaise/Megatron-LM that referenced this pull request May 16, 2026
Upstream main tip: f92a207

Pulled commits:

- f92a207 Update copy-pr-bot.yaml [skip ci]

- b3b6719 ci: tolerate git-gc race in /home/runner chown after checkout (NVIDIA#4808)

- 9b4074b Inference: Optimize Prefill Engine Steps for Nemotron (NVIDIA#4764)

- a53107c chore: Update nightly tests golden values (NVIDIA#4805)

- e9a0930 ci: Update workflow to use same commit for build+test (NVIDIA#4787)

- 266562f Update owners (NVIDIA#4794)

- 98031e1 Bump nvidia-modelopt>=0.44.0 (NVIDIA#4803)

- d167123 fix tokenizers in respect to newer transformers (NVIDIA#4608)

- dbfc96b Use Protocols to type-check linear_proj submodules of Attention (NVIDIA#3434)

Conflict resolutions:

- .github/CODEOWNERS: --theirs (upstream granular team mapping)

- megatron/core/transformer/attention.py: composed -- kept ours StreamBP imports, dropped dead ModuleSpec/build_module import (replaced by Protocol in NVIDIA#3434), kept ours attn_proj_manager pattern because our fine_grained_activation_offload.py keeps group_offload API while upstream split to static group_commit, but adopted apply_module(self.linear_proj) wrapper from NVIDIA#3434

- megatron/core/transformer/multi_latent_attention.py: same apply_module+attn_proj_manager composition; took ours ChunkRange parameter for StreamBP plus upstream BaseInferenceContext type annotation

- pyproject.toml: bumped modelopt >=0.44 (upstream); kept transformer-engine[pytorch,core_cu13]>=2.9.0a0,<2.12.0 pin (custom for CUDA 13 / SM100)

- uv.lock: --ours; modelopt bump is non-breaking. uv lock regenerate blocked by stale /home/sjpat/wheelhouse torchcomms path (pre-existing).

Gates:

- git diff --check: clean

- conflict markers: none

- py_compile (15 changed .py files): OK

- attention.py + multi_latent_attention.py import OK

- indexcache: 27/28 pass (same single GPU-env failure as pre-merge base)

- transformer gdn/mtp/moe suite: 53 failed / 7 passed / 55 skipped / 5 errors -- identical to base (all failures are cudaErrorDevicesUnavailable from sglang occupying all H200s)

- 2-rank torchrun smoke: blocked (no free GPUs)

Custom preserved: StreamBP (megatron/core/transformer/streambp.py + tests/unit_tests/transformer/test_streambp.py + tools/streambp_prod_verify.py), IndexCache config + NVFP4 indexer, HISA topk1024 backward, emerging_optimizers v0.2.0 pin, mHC/MTP/MoE composition.
Victarry pushed a commit to yanring/Megatron-LM that referenced this pull request May 18, 2026
* origin/main: (138 commits)
  Refactor CUDA graph API: decompose cuda_graph_scope into full_iteration impl, inference scope, and per-layer capture modules (NVIDIA#4292)
  Add high-priority A2A stream and HybridEP preprocessing SMs (NVIDIA#4694)
  add is_torch_min_version in fsdp src (NVIDIA#4812)
  [Main][feat] Support A2A Overlap for Megatron-FSDP (NVIDIA#3797)
  Reorder mtp_post_process after attention backward in 1F1B schedule plan (NVIDIA#4695)
  [fix] Use MSC for checking checkpoint existence (NVIDIA#4251)
  Combine GEMM + SwiGLU fused MLP PRs (3890, 4071, 4095, 4219, 4311, 4324) → main (NVIDIA#4636)
  Strengthen test_checkpoint to verify distributed checkpoint behavior (NVIDIA#4711)
  Disable MSC by default; opt in via --enable-msc (NVIDIA#4629)
  additional tests for nvrx (NVIDIA#4522)
  Update copy-pr-bot.yaml [skip ci]
  ci: tolerate git-gc race in /home/runner chown after checkout (NVIDIA#4808)
  Inference: Optimize Prefill Engine Steps for Nemotron (NVIDIA#4764)
  chore: Update nightly tests golden values (NVIDIA#4805)
  ci: Update workflow to use same commit for building docker image and running tests (NVIDIA#4787)
  Update owners (NVIDIA#4794)
  Bump nvidia-modelopt>=0.44.0 (NVIDIA#4803)
  fix tokenizers in respect to newer transformers (NVIDIA#4608)
  Use Protocols to type-check linear_proj submodules of Attention (NVIDIA#3434)
  Fix recompute checkpointing + training CGs (NVIDIA#3919)
  ...

# Conflicts:
#	megatron/core/transformer/moe/moe_utils.py
janEbert pushed a commit to janEbert/Megatron-LM that referenced this pull request Jun 2, 2026
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
…#4808)

Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants