chore: nightly sync main into dev (16_05_2026) - #4831
Closed
svcnvidia-nemo-ci wants to merge 51 commits into
Closed
Conversation
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
…al tests` (#4730) Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com> Co-authored-by: Cory Ye <44509866+cspades@users.noreply.github.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com>
Signed-off-by: Ajay Balasa <abalasa@nvidia.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: Tuomas Rintamaki <trintamaki@nvidia.com> Co-authored-by: Tyler Poon <tylerpoon@gmail.com> Co-authored-by: Collin McCarthy <cmccarthy@nvidia.com> Co-authored-by: Matthieu Le <matthieul@nvidia.com> Co-authored-by: Piotr Zelasko <pzelasko@nvidia.com> Co-authored-by: Ehsan Hosseini Asl <ehosseiniasl@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
…parallel_size * expert_tensor_parallel_size (#4678) Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Co-authored-by: Jorge Albericio <jalbericiola@nvidia.com>
#4509) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
#4492) Signed-off-by: Xiaowei Ren <xren@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
…parallelism correctly (#4687)
svcnvidia-nemo-ci
force-pushed
the
main2dev/16_05_2026
branch
from
May 16, 2026 22:17
886512e to
247fbc0
Compare
Contributor
Author
|
/ok to test 247fbc0 |
Contributor
Author
|
/ok to test 247fbc0 |
- Remove unused TEFusedDenseMLP/nullcontext/CudaGraphScope imports - Drop dense_grouped_gemm parameter not supported by callee - Skip TEFusedDenseMLP test when class is None (main lacks the class) - Restore dev's wheel-safe distributed_data_parallel_config.py (no megatron.core dep)
svcnvidia-nemo-ci
force-pushed
the
main2dev/16_05_2026
branch
from
May 17, 2026 00:44
247fbc0 to
cd222aa
Compare
Contributor
Author
|
/ok to test cd222aa |
Contributor
Author
|
Superseded by today's nightly sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly sync of
mainintodevfor 2026-05-16. Brings in 49 commits frommain, including:Python lines: +13121 / -3926 across 160 files
Files taken from main (per nightly-sync skill)
Files known to have semantic conflicts where dev's versions reference args
or APIs that main removed/renamed:
megatron/training/training.pymegatron/training/initialize.pymegatron/training/utils.pymegatron/training/datasets/data_samplers.pyThese were explicitly checked out from
origin/mainafter the-X theirsmerge so they capture main's caller signatures verbatim.
Files preserved from dev (must not change)
.github/CODEOWNERS— dev's governance file; restored after-X theirsoverrode it.
pyproject.toml,uv.lock,docker/Dockerfile.ci.dev— tightly coupledtriple; dev's versions retain
fast-hadamard-transform,nvidia-resiliency-ext, and the--group no_pypi_wheelsflag that maindoesn't have.
Special handling:
megatron/core/datasets/data_schedule.pyMain and dev have disjoint class sets in this file
(
HybridCPDataLoaderWrapperon main vsBasePackingSchedulerfamily ondev). Verified the merged file retains BOTH sets after
-X theirs, so nomanual surgery needed this cycle.
API mismatches detected and fixed (post-merge surgery)
megatron/core/optimizer/distrib_optimizer.py—copy_main_params_to_model_params:-X theirsproduced a duplicate fp8 quantize-shard loop (main's gatedif fp8 / elif fp4 / else passblock followed by dev's old unconditionalfp8 loop). Removed the duplicate; kept main's
else: passstructure andpreserved dev-only
OptimizerStateOffloaderadditions.megatron/core/transformer/multi_latent_attention.py—forward(): leftover call tooff_interface.group_commit(...)frommain's version of the attn_proj section, but dev's
FineGrainedActivationOffloadingInterfaceexposesgroup_offload(...)instead. Converted to dev's manager pattern.
megatron/core/transformer/attention.py— same fix as above for theattn_proj section.
Git source reconciliation
[tool.uv.sources]in dev'spyproject.tomlcovers everything maindeclares plus dev-only sources (
fast-hadamard-transform,nvidia-resiliency-ext). Only revision difference istransformer-engine(main
42b8400, devf031cf8); kept dev's revision — will revisit if CIreveals an API symbol that requires main's newer revision.
Files restored from main (deleted in dev)
None. Three files exist on main but not on the merged tree
(
.github/workflows/multi-approval-bot.yml,tests/test_utils/recipes/h100/bert.yaml,tests/test_utils/recipes/h100/t5.yaml); all were verified as intentionaldev deletions (see commit
2b4b9c428and40d30942d).Remerge-diff (file-level)
Click to expand merge-conflict file list
Run
git show --remerge-diff 906c09222locally for full per-hunk detail.🤖 Generated by the nightly main-to-dev sync bot.