Skip to content

Update owners - #4794

Merged
ericharper merged 3 commits into
NVIDIA:mainfrom
Phlip79:philip/add-data-parallelism-owner
May 14, 2026
Merged

Update owners#4794
ericharper merged 3 commits into
NVIDIA:mainfrom
Phlip79:philip/add-data-parallelism-owner

Conversation

@Phlip79

@Phlip79 Phlip79 commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  1. Assigning data-parallelism team as codeowner for megatron/core/distributed/
  2. Also, fix distrib_optimizer owner
  3. Add gpt owners to megatron/core/models/common/

@copy-pr-bot

copy-pr-bot Bot commented May 14, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Phlip79
Phlip79 marked this pull request as ready for review May 14, 2026 05:15
@Phlip79
Phlip79 requested a review from a team as a code owner May 14, 2026 05:15
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team May 14, 2026 05:16
@Phlip79

Phlip79 commented May 14, 2026

Copy link
Copy Markdown
Member Author

/ok to test 9e71303

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label May 14, 2026
@Phlip79 Phlip79 changed the title Add data-parallelism owner Update owners May 14, 2026
@Phlip79

Phlip79 commented May 14, 2026

Copy link
Copy Markdown
Member Author

/ok to test 0b48b14

@Phlip79

Phlip79 commented May 14, 2026

Copy link
Copy Markdown
Member Author

/ok to test d75e340

@ericharper
ericharper added this pull request to the merge queue May 14, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented May 14, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25888013238

Merged via the queue into NVIDIA:main with commit 266562f May 14, 2026
68 of 70 checks passed
SpencerGarnets added a commit to ai-blaise/Megatron-LM that referenced this pull request May 16, 2026
@SpencerGarnets
Merge NVIDIA Megatron-LM main into upstream-dev
fe02261 
Upstream main tip: f92a207

Pulled commits:

- f92a207 Update copy-pr-bot.yaml [skip ci]

- b3b6719 ci: tolerate git-gc race in /home/runner chown after checkout (NVIDIA#4808)

- 9b4074b Inference: Optimize Prefill Engine Steps for Nemotron (NVIDIA#4764)

- a53107c chore: Update nightly tests golden values (NVIDIA#4805)

- e9a0930 ci: Update workflow to use same commit for build+test (NVIDIA#4787)

- 266562f Update owners (NVIDIA#4794)

- 98031e1 Bump nvidia-modelopt>=0.44.0 (NVIDIA#4803)

- d167123 fix tokenizers in respect to newer transformers (NVIDIA#4608)

- dbfc96b Use Protocols to type-check linear_proj submodules of Attention (NVIDIA#3434)

Conflict resolutions:

- .github/CODEOWNERS: --theirs (upstream granular team mapping)

- megatron/core/transformer/attention.py: composed -- kept ours StreamBP imports, dropped dead ModuleSpec/build_module import (replaced by Protocol in NVIDIA#3434), kept ours attn_proj_manager pattern because our fine_grained_activation_offload.py keeps group_offload API while upstream split to static group_commit, but adopted apply_module(self.linear_proj) wrapper from NVIDIA#3434

- megatron/core/transformer/multi_latent_attention.py: same apply_module+attn_proj_manager composition; took ours ChunkRange parameter for StreamBP plus upstream BaseInferenceContext type annotation

- pyproject.toml: bumped modelopt >=0.44 (upstream); kept transformer-engine[pytorch,core_cu13]>=2.9.0a0,<2.12.0 pin (custom for CUDA 13 / SM100)

- uv.lock: --ours; modelopt bump is non-breaking. uv lock regenerate blocked by stale /home/sjpat/wheelhouse torchcomms path (pre-existing).

Gates:

- git diff --check: clean

- conflict markers: none

- py_compile (15 changed .py files): OK

- attention.py + multi_latent_attention.py import OK

- indexcache: 27/28 pass (same single GPU-env failure as pre-merge base)

- transformer gdn/mtp/moe suite: 53 failed / 7 passed / 55 skipped / 5 errors -- identical to base (all failures are cudaErrorDevicesUnavailable from sglang occupying all H200s)

- 2-rank torchrun smoke: blocked (no free GPUs)

Custom preserved: StreamBP (megatron/core/transformer/streambp.py + tests/unit_tests/transformer/test_streambp.py + tools/streambp_prod_verify.py), IndexCache config + NVFP4 indexer, HISA topk1024 backward, emerging_optimizers v0.2.0 pin, mHC/MTP/MoE composition.
Victarry pushed a commit to yanring/Megatron-LM that referenced this pull request May 18, 2026
Dennis Liu
Merge remote-tracking branch 'origin/main' into pr3431-conflict-fix
fc1ec88 
* origin/main: (138 commits)
  Refactor CUDA graph API: decompose cuda_graph_scope into full_iteration impl, inference scope, and per-layer capture modules (NVIDIA#4292)
  Add high-priority A2A stream and HybridEP preprocessing SMs (NVIDIA#4694)
  add is_torch_min_version in fsdp src (NVIDIA#4812)
  [Main][feat] Support A2A Overlap for Megatron-FSDP (NVIDIA#3797)
  Reorder mtp_post_process after attention backward in 1F1B schedule plan (NVIDIA#4695)
  [fix] Use MSC for checking checkpoint existence (NVIDIA#4251)
  Combine GEMM + SwiGLU fused MLP PRs (3890, 4071, 4095, 4219, 4311, 4324) → main (NVIDIA#4636)
  Strengthen test_checkpoint to verify distributed checkpoint behavior (NVIDIA#4711)
  Disable MSC by default; opt in via --enable-msc (NVIDIA#4629)
  additional tests for nvrx (NVIDIA#4522)
  Update copy-pr-bot.yaml [skip ci]
  ci: tolerate git-gc race in /home/runner chown after checkout (NVIDIA#4808)
  Inference: Optimize Prefill Engine Steps for Nemotron (NVIDIA#4764)
  chore: Update nightly tests golden values (NVIDIA#4805)
  ci: Update workflow to use same commit for building docker image and running tests (NVIDIA#4787)
  Update owners (NVIDIA#4794)
  Bump nvidia-modelopt>=0.44.0 (NVIDIA#4803)
  fix tokenizers in respect to newer transformers (NVIDIA#4608)
  Use Protocols to type-check linear_proj submodules of Attention (NVIDIA#3434)
  Fix recompute checkpointing + training CGs (NVIDIA#3919)
  ...

# Conflicts:
#	megatron/core/transformer/moe/moe_utils.py
janEbert pushed a commit to janEbert/Megatron-LM that referenced this pull request Jun 2, 2026
@Phlip79 @janEbert
Update owners (NVIDIA#4794)
152e1f1
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
@Phlip79 @yhgalaxy
Update owners (NVIDIA#4794)
9ce6ffb 
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
@Phlip79 Jon Barker
Update owners (NVIDIA#4794)
a522ede 
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
@Phlip79 @terminator123
Update owners (NVIDIA#4794)
9b83b25
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
@Phlip79 @dimapihtar
Update owners (NVIDIA#4794)
3521e16 
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balasaajay balasaajay balasaajay approved these changes

Assignees

No one assigned

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Phlip79 @svcnvidia-nemo-ci @balasaajay @ericharper