Skip to content

Added support for ECC to Key Vault#1538

Merged
dsgouda merged 1 commit intoAzure:currentfrom
msfcolombo:current
Aug 15, 2017
Merged

Added support for ECC to Key Vault#1538
dsgouda merged 1 commit intoAzure:currentfrom
msfcolombo:current

Conversation

@msfcolombo
Copy link
Copy Markdown
Contributor

@msfcolombo msfcolombo commented Aug 14, 2017 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link
Copy Markdown

msftclas commented Aug 14, 2017

@msfcolombo,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@msfcolombo
Copy link
Copy Markdown
Contributor Author

msfcolombo commented Aug 14, 2017 •
edited
Loading

@salameer @dsgouda @olydis @sergey-shandar

Hi folks. Blaming readme.md for your contact, since there is no DL there.

A fiew questions:

  • The @azuresdkciprbot is telling we have 31 errors before and after this PR. Is the fix required for merging?
  • The Travis build here reports error in cognitiveservices (???). That has nothing to do with my changes. Is there someone looking into that, or should I open a new issue?

Thanks!

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Aug 15, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/keyvault/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 31
After the PR: Warning(s): 0 Error(s): 31

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

1 similar comment
@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Aug 15, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/keyvault/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 31
After the PR: Warning(s): 0 Error(s): 31

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

dsgouda
dsgouda approved these changes Aug 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 4a9084f into Azure:current Aug 15, 2017
@AutorestCI AutorestCI mentioned this pull request Aug 15, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 15, 2017

Build Status Azure/azure-sdk-for-python#1368

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 15, 2017

No modification for AutorestCI/azure-sdk-for-node

1 similar comment
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 15, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 16, 2017

No modification for AutorestCI/azure-sdk-for-ruby

@msfcolombo msfcolombo mentioned this pull request Aug 16, 2017
Closed
8 tasks
schaabs pushed a commit to schaabs/azure-rest-api-specs that referenced this pull request Aug 18, 2017
Revert "Added support for ECC to Key Vault (Azure#1538)"
0db4c70 
This reverts commit 4a9084f.
@schaabs schaabs mentioned this pull request Aug 18, 2017
Merged
olydis pushed a commit that referenced this pull request Aug 18, 2017
@olydis
Revert "Added support for ECC to Key Vault" (#1564)
d562b7d 
* Revert "[Event Grid] Event grid C# code generation section. (#1561)"

This reverts commit 461a494.

* Revert "Bug Fix when linter runs on json file without being included in tag (#1560)"

This reverts commit d6bc117.

* Revert "Remove databaseName uri param from Databases_Import op. (#1558)"

This reverts commit 69d0a5d.

* Revert "Added 200 response for event grid event subscription delete operation. (#1555)"

This reverts commit ad55af7.

* Revert "Add some content to Swagger from docs.msft.com (#1549)"

This reverts commit b955458.

* Revert "[Azure Analysis Services] Add gateway info to version 0714 and version 0801 (#1526)"

This reverts commit bf407b7.

* Revert "Copied service endpoints specs to 2017-08-01 (#1548)"

This reverts commit 64c905a.

* Revert "Removed `x-ms-pageable` from Network Interface's `GetEffectiveRouteTable` and `ListEffectiveNetworkSecurityGroups` methods (#1547)"

This reverts commit da940d5.

* Revert "Added service endpoints APIs (#1533)"

This reverts commit f69dc64.

* Revert "Added support for ECC to Key Vault (#1538)"

This reverts commit 4a9084f.
hrkulkarMsft pushed a commit to hrkulkarMsft/azure-rest-api-specs that referenced this pull request Aug 22, 2017
@amarzavery @veronicagg
Integrating public current to private current as of 8/15/2017 - 4:56 …
a8a3ce0 
…PM PST (Azure#115)

* updating spec for file type to comply with schema (Azure#1544)

* Added support for ECC to Key Vault (Azure#1538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@msfcolombo @msftclas @azuresdkciprbot @AutorestCI @dsgouda