Added service endpoints APIs by EvgenyAgafonchikov · Pull Request #1533 · Azure/azure-rest-api-specs

EvgenyAgafonchikov · 2017-08-11T09:37:02Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkciprbot · 2017-08-11T09:47:32Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 150 Error(s): 83
After the PR: Warning(s): 150 Error(s): 83

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

sergey-shandar · 2017-08-11T18:19:10Z

@ravbhatnagar New swagger file.

sergey-shandar

Waiting for ARM feedback.

DeepakRajendranMsft · 2017-08-15T21:52:42Z

Ping....Why does this need ARM review again? this has already been reviewed by them. we are renaming this property. so we had to remove and replace it back. @sergey-shandar @ravbhatnagar

sergey-shandar · 2017-08-15T22:08:59Z

@DeepakRajendranMsft I see a new file Microsoft.Network/2017-06-01/endpointService.json. Could you send a link to the ARM review for this file?

DeepakRajendranMsft · 2017-08-15T22:11:11Z

this is the PR where we dropped it #1486. we wouldnt have put in there if we didnt get ARM approval :)

sergey-shandar · 2017-08-15T22:17:27Z

@ravbhatnagar could you confirm ARM review? I still can't see a ARM review confirmation for the new file.

ravbhatnagar · 2017-08-15T22:28:37Z

@sergey-shandar - looks good.

DeepakRajendranMsft · 2017-08-15T22:53:32Z

@sergey-shandar can this be merged please

sergey-shandar · 2017-08-15T22:55:45Z

specification/network/resource-manager/Microsoft.Network/2017-06-01/virtualNetwork.json

          "$ref": "./routeTable.json#/definitions/RouteTable",
          "description": "The reference of the RouteTable resource."
        },
+        "serviceEndpoints": {


@EvgenyAgafonchikov @ravbhatnagar this property is used in response which may introduce API breaking changes, or SDK breaking changes if it's used in GET-PUT scenario. If we don't plan to use it in such scenario, we should mark it as "read only".

@amarzavery @salameer this is well documented and we are okay with the breaking change.
it is read-write property.

@ravbhatnagar can you sign off on this new additional property.

ravbhatnagar · 2017-08-16T00:54:06Z

@DeepakRajendranMsft - Is this again the same case where it has already been added on the service side for this api-version and swagger update is happening now?

DeepakRajendranMsft · 2017-08-16T01:45:34Z

@ravbhatnagar yes. because we did a rename of the property.

ravbhatnagar · 2017-08-16T01:46:32Z

@sergey-shandar - ARM signs off.

AutorestCI · 2017-08-16T06:14:37Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-08-16T06:15:04Z

Azure/azure-sdk-for-ruby#896

AutorestCI · 2017-08-16T06:16:51Z

Azure/azure-sdk-for-python#1369

This reverts commit f69dc64.

* Revert "[Event Grid] Event grid C# code generation section. (#1561)" This reverts commit 461a494. * Revert "Bug Fix when linter runs on json file without being included in tag (#1560)" This reverts commit d6bc117. * Revert "Remove databaseName uri param from Databases_Import op. (#1558)" This reverts commit 69d0a5d. * Revert "Added 200 response for event grid event subscription delete operation. (#1555)" This reverts commit ad55af7. * Revert "Add some content to Swagger from docs.msft.com (#1549)" This reverts commit b955458. * Revert "[Azure Analysis Services] Add gateway info to version 0714 and version 0801 (#1526)" This reverts commit bf407b7. * Revert "Copied service endpoints specs to 2017-08-01 (#1548)" This reverts commit 64c905a. * Revert "Removed `x-ms-pageable` from Network Interface's `GetEffectiveRouteTable` and `ListEffectiveNetworkSecurityGroups` methods (#1547)" This reverts commit da940d5. * Revert "Added service endpoints APIs (#1533)" This reverts commit f69dc64. * Revert "Added support for ECC to Key Vault (#1538)" This reverts commit 4a9084f.

Added service endpoints APIs

04b6909

msftclas added the cla-already-signed label Aug 11, 2017

azuresdkci assigned sergey-shandar Aug 11, 2017

sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 11, 2017

sergey-shandar suggested changes Aug 14, 2017

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 15, 2017

sergey-shandar added the potential-sdk-breaking-change label Aug 15, 2017

sergey-shandar suggested changes Aug 15, 2017

View reviewed changes

sergey-shandar approved these changes Aug 16, 2017

View reviewed changes

sergey-shandar merged commit f69dc64 into Azure:current Aug 16, 2017

AutorestCI mentioned this pull request Aug 16, 2017

Automatic PR from RestAPI-PR1533 Azure/azure-sdk-for-ruby#896

Closed

AutorestCI mentioned this pull request Aug 16, 2017

Automatic PR from RestAPI-PR1533 Azure/azure-sdk-for-python#1369

Closed

DeepakRajendranMsft mentioned this pull request Aug 16, 2017

Copied service endpoints specs to 2017-08-01 #1548

Merged

10 tasks

schaabs pushed a commit to schaabs/azure-rest-api-specs that referenced this pull request Aug 18, 2017

Revert "Added service endpoints APIs (Azure#1533)"

ca286d7

This reverts commit f69dc64.

EvgenyAgafonchikov deleted the endpoints branch May 15, 2019 07:20

Conversation

EvgenyAgafonchikov commented Aug 11, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkciprbot commented Aug 11, 2017

Uh oh!

sergey-shandar commented Aug 11, 2017

Uh oh!

sergey-shandar left a comment

Choose a reason for hiding this comment

Uh oh!

DeepakRajendranMsft commented Aug 15, 2017

Uh oh!

sergey-shandar commented Aug 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DeepakRajendranMsft commented Aug 15, 2017

Uh oh!

sergey-shandar commented Aug 15, 2017

Uh oh!

ravbhatnagar commented Aug 15, 2017

Uh oh!

DeepakRajendranMsft commented Aug 15, 2017

Uh oh!

sergey-shandar Aug 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DeepakRajendranMsft Aug 16, 2017

Choose a reason for hiding this comment

Uh oh!

DeepakRajendranMsft Aug 16, 2017

Choose a reason for hiding this comment

Uh oh!

ravbhatnagar commented Aug 16, 2017

Uh oh!

DeepakRajendranMsft commented Aug 16, 2017

Uh oh!

ravbhatnagar commented Aug 16, 2017

Uh oh!

AutorestCI commented Aug 16, 2017

Uh oh!

AutorestCI commented Aug 16, 2017

Uh oh!

AutorestCI commented Aug 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

EvgenyAgafonchikov commented Aug 11, 2017 •

edited by azuresdkci

Loading

sergey-shandar commented Aug 15, 2017 •

edited

Loading

sergey-shandar Aug 15, 2017 •

edited

Loading