[KeyVault] Added support for ECC to Key Vault#1368
[KeyVault] Added support for ECC to Key Vault#1368AutorestCI wants to merge 1 commit intoAzure:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
+ Coverage 54.82% 54.82% +<.01%
==========================================
Files 3012 3012
Lines 75844 75858 +14
==========================================
+ Hits 41578 41592 +14
Misses 34266 34266
Continue to review full report at Codecov.
|
lmazuel
changed the title
lmazuel
left a comment
lmazuel
left a comment
There was a problem hiding this comment.
"curve" seems to have been added in the middle of the parameters list. If it's not on purpose, it's unfortunate because it's a breaking change that could be avoided by just putting new optional parameter at the end of the Swagger
|
|
||
| def create_key( | ||
| self, vault_base_url, key_name, kty, key_size=None, key_ops=None, key_attributes=None, tags=None, custom_headers=None, raw=False, **operation_config): | ||
| self, vault_base_url, key_name, kty, curve=None, key_size=None, key_ops=None, key_attributes=None, tags=None, custom_headers=None, raw=False, **operation_config): |
There was a problem hiding this comment.
This is breaking, and might be avoided by just putting this parameter later at the end in the parameter list in the Swagger.
| :rtype: :class:`KeyBundle <azure.keyvault.models.KeyBundle>` | ||
| :rtype: :class:`ClientRawResponse<msrest.pipeline.ClientRawResponse>` | ||
| if raw=true | ||
| :return: :class:`KeyBundle <azure.keyvault.models.KeyBundle>` or |
There was a problem hiding this comment.
FYI all these docstring update are new Autorest, improved by the feedback from docs.microsoft.com
| path_format_arguments = { | ||
| 'vaultBaseUrl': self._serialize.url("vault_base_url", vault_base_url, 'str', skip_quote=True), | ||
| 'key-name': self._serialize.url("key_name", key_name, 'str', pattern='^[0-9a-zA-Z-]+$') | ||
| 'key-name': self._serialize.url("key_name", key_name, 'str', pattern=r'^[0-9a-zA-Z-]+$') |
| class CertificateIssuerItemPaged(Paged): | ||
| """ | ||
| A paging container for iterating over a list of CertificateIssuerItem object | ||
| A paging container for iterating over a list of :class:`CertificateIssuerItem <azure.keyvault.models.CertificateIssuerItem>` object |
schaabs
left a comment
schaabs
left a comment
There was a problem hiding this comment.
Rejecting this change. We're going to update the swagger so the generated code is backwards compatible.
5 participants
Generated from RestAPI PR: Azure/azure-rest-api-specs#1538