Skip to content

Copied service endpoints specs to 2017-08-01#1548

Merged
sergey-shandar merged 2 commits intoAzure:currentfrom
EvgenyAgafonchikov:endpoints-2017-08-01
Aug 16, 2017
Merged

Copied service endpoints specs to 2017-08-01#1548
sergey-shandar merged 2 commits intoAzure:currentfrom
EvgenyAgafonchikov:endpoints-2017-08-01

Conversation

@EvgenyAgafonchikov
Copy link
Copy Markdown
Contributor

@EvgenyAgafonchikov EvgenyAgafonchikov commented Aug 16, 2017 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Aug 16, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 83
After the PR: Warning(s): 151 Error(s): 83

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Aug 16, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 83
After the PR: Warning(s): 151 Error(s): 84

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@DeepakRajendranMsft
Copy link
Copy Markdown
Contributor

DeepakRajendranMsft commented Aug 16, 2017

@sergey-shandar could you also please take a look. this is the same PR as #1533
we are porting the changes to 2017-08-01
Thanks!

sergey-shandar
sergey-shandar reviewed Aug 16, 2017
View reviewed changes
specification/network/resource-manager/Microsoft.Network/2017-08-01/virtualNetwork.json
"$ref": "./routeTable.json#/definitions/RouteTable",
"description": "The reference of the RouteTable resource."
},
"serviceEndpoints": {
Copy link
Copy Markdown
Contributor

@sergey-shandar sergey-shandar Aug 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This's breaking changes, same as here #1533

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2017
@sergey-shandar
Copy link
Copy Markdown
Contributor

sergey-shandar commented Aug 16, 2017

@ravbhatnagar It's the same as #1533 and contains the same breaking changes

@DeepakRajendranMsft
Copy link
Copy Markdown
Contributor

DeepakRajendranMsft commented Aug 16, 2017

@ravbhatnagar can you signoff on this again please, not sure why it is required but please do it.
@salameer this is just an another example of more processes that we have in the system. this change has already been approved by the ARM team for 06-01, not sure why we need their sign off again for 08-01

@ravbhatnagar
Copy link
Copy Markdown
Contributor

ravbhatnagar commented Aug 16, 2017

@sergey-shandar Wasnt this already signed off? ARM signs off.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 16, 2017
@sergey-shandar
Copy link
Copy Markdown
Contributor

sergey-shandar commented Aug 16, 2017

@ravbhatnagar for different API version.

@sergey-shandar sergey-shandar merged commit 64c905a into Azure:current Aug 16, 2017
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 16, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Aug 16, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 16, 2017

Build Status Azure/azure-sdk-for-python#1371

@AutorestCI AutorestCI mentioned this pull request Aug 16, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 16, 2017

Build Status Azure/azure-sdk-for-ruby#898

schaabs pushed a commit to schaabs/azure-rest-api-specs that referenced this pull request Aug 18, 2017
Revert "Copied service endpoints specs to 2017-08-01 (Azure#1548)"
3093da2 
This reverts commit 64c905a.
olydis pushed a commit that referenced this pull request Aug 18, 2017
@olydis
Revert "Added support for ECC to Key Vault" (#1564)
d562b7d 
* Revert "[Event Grid] Event grid C# code generation section. (#1561)"

This reverts commit 461a494.

* Revert "Bug Fix when linter runs on json file without being included in tag (#1560)"

This reverts commit d6bc117.

* Revert "Remove databaseName uri param from Databases_Import op. (#1558)"

This reverts commit 69d0a5d.

* Revert "Added 200 response for event grid event subscription delete operation. (#1555)"

This reverts commit ad55af7.

* Revert "Add some content to Swagger from docs.msft.com (#1549)"

This reverts commit b955458.

* Revert "[Azure Analysis Services] Add gateway info to version 0714 and version 0801 (#1526)"

This reverts commit bf407b7.

* Revert "Copied service endpoints specs to 2017-08-01 (#1548)"

This reverts commit 64c905a.

* Revert "Removed `x-ms-pageable` from Network Interface's `GetEffectiveRouteTable` and `ListEffectiveNetworkSecurityGroups` methods (#1547)"

This reverts commit da940d5.

* Revert "Added service endpoints APIs (#1533)"

This reverts commit f69dc64.

* Revert "Added support for ECC to Key Vault (#1538)"

This reverts commit 4a9084f.
@EvgenyAgafonchikov EvgenyAgafonchikov deleted the endpoints-2017-08-01 branch May 15, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sergey-shandar sergey-shandar sergey-shandar approved these changes

@DeepakRajendranMsft DeepakRajendranMsft DeepakRajendranMsft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@EvgenyAgafonchikov @azuresdkciprbot @DeepakRajendranMsft @sergey-shandar @ravbhatnagar @AutorestCI @fearthecowboy @msftclas