Skip to content

[Network] Removed x-ms-pageable from LROs in NetworkInterface#1547

Merged
sergey-shandar merged 1 commit intoAzure:currentfrom
anton-evseev:pageable-revert
Aug 16, 2017
Merged

[Network] Removed x-ms-pageable from LROs in NetworkInterface#1547
sergey-shandar merged 1 commit intoAzure:currentfrom
anton-evseev:pageable-revert

Conversation

@anton-evseev
Copy link
Copy Markdown
Contributor

@anton-evseev anton-evseev commented Aug 16, 2017

Autorest doesn't support pageable LROs for some languages so x-ms-pageable is being removed until Autorest is updated.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

…ble` and `ListEffectiveNetworkSecurityGroups` methods
@msftclas
Copy link
Copy Markdown

@number213,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 83
After the PR: Warning(s): 151 Error(s): 83

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

Copy link
Copy Markdown
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to related AutoRest issue Azure/autorest#2538

@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

@anton-evseev anton-evseev deleted the pageable-revert branch August 18, 2017 08:48
schaabs pushed a commit to schaabs/azure-rest-api-specs that referenced this pull request Aug 18, 2017
…eRouteTable` and `ListEffectiveNetworkSecurityGroups` methods (Azure#1547)"

This reverts commit da940d5.
olydis pushed a commit that referenced this pull request Aug 18, 2017
* Revert "[Event Grid] Event grid C# code generation section. (#1561)"

This reverts commit 461a494.

* Revert "Bug Fix when linter runs on json file without being included in tag (#1560)"

This reverts commit d6bc117.

* Revert "Remove databaseName uri param from Databases_Import op. (#1558)"

This reverts commit 69d0a5d.

* Revert "Added 200 response for event grid event subscription delete operation. (#1555)"

This reverts commit ad55af7.

* Revert "Add some content to Swagger from docs.msft.com (#1549)"

This reverts commit b955458.

* Revert "[Azure Analysis Services] Add gateway info to version 0714 and version 0801 (#1526)"

This reverts commit bf407b7.

* Revert "Copied service endpoints specs to 2017-08-01 (#1548)"

This reverts commit 64c905a.

* Revert "Removed `x-ms-pageable` from Network Interface's `GetEffectiveRouteTable` and `ListEffectiveNetworkSecurityGroups` methods (#1547)"

This reverts commit da940d5.

* Revert "Added service endpoints APIs (#1533)"

This reverts commit f69dc64.

* Revert "Added support for ECC to Key Vault (#1538)"

This reverts commit 4a9084f.
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Microsoft.Bing Api Specification swagger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants