Skip to content

updating spec for file type to comply with schema#1544

Merged
veronicagg merged 1 commit intoAzure:currentfrom
veronicagg:file-type
Aug 15, 2017
Merged

updating spec for file type to comply with schema#1544
veronicagg merged 1 commit intoAzure:currentfrom
veronicagg:file-type

Conversation

@veronicagg
Copy link
Copy Markdown
Contributor

@veronicagg veronicagg commented Aug 15, 2017

Face.json is currently not complying with swagger 2.0 spec (per schema), which is currently breaking CI in the repo.
Swagger 2.0 Schema: https://github.com/OAI/OpenAPI-Specification/blob/master/schemas/v2.0/schema.json
which is the base for the extended one we use at https://github.com/Azure/autorest/blob/master/schema/swagger-extensions.json

See related thread: OAI/OpenAPI-Specification#1226

Making an update to an equivalent type/format, which produces the same generated code via AutoRest.

Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! I'll re-start the CI once PR Azure/autorest#2529 is merged for CI to pass.

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/cognitiveservices/data-plane/Face/readme.md
Before the PR: Warning(s): 87 Error(s): 16
After the PR: Warning(s): 87 Error(s): 16

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@fearthecowboy
Copy link
Copy Markdown
Contributor

o_O

Why are we reverting this and switching the way that it's specified?

I thought we were good with

"schema": {
  "type":"file" 
}

given that the spec (https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#data-types) clearly states:

Primitive data types in the Swagger Specification are based on the types supported by the JSON-Schema Draft 4. Models are described using the Schema Object which is a subset of JSON Schema Draft 4.
An additional primitive data type "file" is used by the Parameter Object and the Response Object to set the parameter type or the response as being a file.

@veronicagg
Copy link
Copy Markdown
Contributor Author

talked to @fearthecowboy offline and agreed on making this change at this time, to comply with swagger 2.0 schema. See links referenced above for more info.

@veronicagg veronicagg merged commit b86b83c into Azure:current Aug 15, 2017
@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/cognitiveservices/data-plane/Face/readme.md
Before the PR: Warning(s): 87 Error(s): 16
After the PR: Warning(s): 87 Error(s): 16

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-python

hrkulkarMsft pushed a commit to hrkulkarMsft/azure-rest-api-specs that referenced this pull request Aug 22, 2017
…PM PST (Azure#115)

* updating spec for file type to comply with schema (Azure#1544)

* Added support for ECC to Key Vault (Azure#1538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants