updating spec for file type to comply with schema#1544
updating spec for file type to comply with schema#1544veronicagg merged 1 commit intoAzure:currentfrom
Conversation
vishrutshah
left a comment
There was a problem hiding this comment.
Changes LGTM! I'll re-start the CI once PR Azure/autorest#2529 is merged for CI to pass.
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
|
o_O Why are we reverting this and switching the way that it's specified? I thought we were good with "schema": {
"type":"file"
}given that the spec (https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#data-types) clearly states:
|
|
talked to @fearthecowboy offline and agreed on making this change at this time, to comply with swagger 2.0 schema. See links referenced above for more info. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
|
No modification for AutorestCI/azure-sdk-for-node |
|
No modification for AutorestCI/azure-sdk-for-ruby |
|
No modification for AutorestCI/azure-sdk-for-python |
…PM PST (Azure#115) * updating spec for file type to comply with schema (Azure#1544) * Added support for ECC to Key Vault (Azure#1538)
Face.json is currently not complying with swagger 2.0 spec (per schema), which is currently breaking CI in the repo.
Swagger 2.0 Schema: https://github.com/OAI/OpenAPI-Specification/blob/master/schemas/v2.0/schema.json
which is the base for the extended one we use at https://github.com/Azure/autorest/blob/master/schema/swagger-extensions.json
See related thread: OAI/OpenAPI-Specification#1226
Making an update to an equivalent type/format, which produces the same generated code via AutoRest.