Skip to content

Remove databaseName uri param from Databases_Import op.#1558

Merged
dsgouda merged 1 commit intoAzure:currentfrom
jaredmoo:importexample
Aug 17, 2017
Merged

Remove databaseName uri param from Databases_Import op.#1558
dsgouda merged 1 commit intoAzure:currentfrom
jaredmoo:importexample

Conversation

@jaredmoo
Copy link
Copy Markdown
Contributor

@jaredmoo jaredmoo commented Aug 17, 2017 •
edited by azuresdkci
Loading

The URI for this operation is "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/import", databaseName is not a uri param.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@jaredmoo
Remove databaseName uri param from Databases_Import op.
12a4912 
The URI for this operation is "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/import", databaseName is not a uri param.
@jaredmoo
Copy link
Copy Markdown
Contributor Author

jaredmoo commented Aug 17, 2017

@nathannfan fyi

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Aug 17, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/sql/resource-manager/readme.md
Before the PR: Warning(s): 4 Error(s): 0
After the PR: Warning(s): 4 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Aug 17, 2017

Looks like the Databases_CreateImportOperation operation still contains the databaseName parameter in importExport.json, am I missing something here?

@jaredmoo
Copy link
Copy Markdown
Contributor Author

jaredmoo commented Aug 17, 2017

There are 2 different import operations:

  1. Databases_Import, which has db name in the request body
  2. Databases_CreateImportOperation, which has db name in the uri.

This is fixing the Databases_Import examples which incorrectly have db name in the uri.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Aug 17, 2017

Thanks for that.

dsgouda
dsgouda approved these changes Aug 17, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, non intrusive change

@dsgouda dsgouda merged commit 69d0a5d into Azure:current Aug 17, 2017
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 17, 2017

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 17, 2017

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 17, 2017

No modification for AutorestCI/azure-sdk-for-node

schaabs pushed a commit to schaabs/azure-rest-api-specs that referenced this pull request Aug 18, 2017
Revert "Remove databaseName uri param from Databases_Import op. (Azur…
c410d18 
…e#1558)"

This reverts commit 69d0a5d.
olydis pushed a commit that referenced this pull request Aug 18, 2017
@olydis
Revert "Added support for ECC to Key Vault" (#1564)
d562b7d 
* Revert "[Event Grid] Event grid C# code generation section. (#1561)"

This reverts commit 461a494.

* Revert "Bug Fix when linter runs on json file without being included in tag (#1560)"

This reverts commit d6bc117.

* Revert "Remove databaseName uri param from Databases_Import op. (#1558)"

This reverts commit 69d0a5d.

* Revert "Added 200 response for event grid event subscription delete operation. (#1555)"

This reverts commit ad55af7.

* Revert "Add some content to Swagger from docs.msft.com (#1549)"

This reverts commit b955458.

* Revert "[Azure Analysis Services] Add gateway info to version 0714 and version 0801 (#1526)"

This reverts commit bf407b7.

* Revert "Copied service endpoints specs to 2017-08-01 (#1548)"

This reverts commit 64c905a.

* Revert "Removed `x-ms-pageable` from Network Interface's `GetEffectiveRouteTable` and `ListEffectiveNetworkSecurityGroups` methods (#1547)"

This reverts commit da940d5.

* Revert "Added service endpoints APIs (#1533)"

This reverts commit f69dc64.

* Revert "Added support for ECC to Key Vault (#1538)"

This reverts commit 4a9084f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jaredmoo @azuresdkciprbot @dsgouda @AutorestCI @msftclas