Skip to content

fix: resolve merge-train conflict with next (zig wrapper scripts + -g0)#21201

Merged
johnathan79717 merged 17 commits intomerge-train/barretenbergfrom
jh/fix-merge-train-conflict
Mar 6, 2026
Merged

fix: resolve merge-train conflict with next (zig wrapper scripts + -g0)#21201
johnathan79717 merged 17 commits intomerge-train/barretenbergfrom
jh/fix-merge-train-conflict

Conversation

@johnathan79717
Copy link
Contributor

@johnathan79717 johnathan79717 commented Mar 6, 2026

Summary

  • Resolves merge conflict in barretenberg/cpp/CMakePresets.json between merge-train/barretenberg and next
    • Keeps next's zig wrapper scripts (zig-cc.sh/zig-c++.sh) for cross-platform support
    • Preserves merge-train's -g0 CFLAGS/CXXFLAGS to eliminate debug info bloat

charlielye and others added 17 commits March 5, 2026 16:34
Tweaks and builds upon gregos
#19379.
You can install dependencies prior to bootstrapping with.
```
./bootstrap.sh install_deps
```
You can then:
```
./bootstrap.sh gentle
```
To trigger a makefile build with 1 job at a time, and cmake will target
nproc parallelism -2, and a MEMSUSPEND at 1g.

Tested on fresh macos 15/26 install + brew.

Didn't build on macos 14. Looks hairy, not important.

---------

Co-authored-by: Jonathan Hao <jonathan@aztec-labs.com>
This is necessary to make calling contract functions with Option params
relatively straightforward.
Minor inconsistency spotted by @nchamo.
Originally requested by @xorsal and @zkfrov.

This simply adds a new `deploy_opts` function which takes
`DeployOptions`, via which custom salt and secret can be speficied. In
the future we might be able to allow specifying more things.

The bigger change is that the deployment oraacle now supports salt,
secret (and deployer, currently hardcoded), so we should not need to
break this API in the near future.

Closes #16656

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Martin Verzilli <martin@aztec-labs.com>
BEGIN_COMMIT_OVERRIDE
chore: Support for building aztec-packages on mac. (#20581)
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
fix: empty undefined offchain messages for batch calls (#21157)
feat: add aztecaddress::is_valid (#21072)
feat: add ergonomic conversions for Noir's `Option<T>` (#21107)
chore: use returns `true` for boolean fns (#21186)
feat: add salt and secret params to env.deploy (#21183)
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
docs: clarifying Noir fields vs struct fields in event metadata (#21172)
END_COMMIT_OVERRIDE
# Conflicts:
#	barretenberg/cpp/CMakePresets.json
@johnathan79717 johnathan79717 changed the title fix: resolve merge conflict with next (zig wrapper scripts + -g0) fix: resolve merge-train conflict and increase WASM SRS size Mar 6, 2026
@johnathan79717 johnathan79717 changed the title fix: resolve merge-train conflict and increase WASM SRS size fix: resolve merge-train conflict with next (zig wrapper scripts + -g0) Mar 6, 2026
@johnathan79717 johnathan79717 enabled auto-merge (squash) March 6, 2026 12:55
@johnathan79717 johnathan79717 requested review from federicobarbacovi and notnotraju and removed request for federicobarbacovi March 6, 2026 12:56
@johnathan79717 johnathan79717 disabled auto-merge March 6, 2026 14:39
@johnathan79717 johnathan79717 force-pushed the jh/fix-merge-train-conflict branch from 7293de8 to a7f7255 Compare March 6, 2026 14:40
@johnathan79717 johnathan79717 merged commit 652ca4b into merge-train/barretenberg Mar 6, 2026
14 of 18 checks passed
@johnathan79717 johnathan79717 deleted the jh/fix-merge-train-conflict branch March 6, 2026 14:42
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2026
BEGIN_COMMIT_OVERRIDE
fix: add -g0 to zig presets to eliminate 11GB debug info bloat (#21071)
fix: resolve flaky p2p_client test race condition on ARM64 (#21088)
chore: remove domain iteration macros and address backing memory race
(#20988)
fix: [ECCVM] added domain separation for the multiset equality check.
(#20352)
feat: hybrid CRS hash verification — 8MB chunks, parallel, span-based
(#21113)
chore: unify splitting scalars interface (#20805)
chore: add a unique id to each origin tag (#20924)
chore: Native curve audit (#20936)
chore: Update bootstrap in test vk haven't changed script (#21153)
fix: use reduced form in WASM FromMontgomeryForm test (#21164)
chore: erase ephemeral secrets from memory in schnorr and aes (#21106)
chore: suppress clangd target triple version diagnostic (#21180)
feat: Optimise new claim calculation (#21179)
docs: add Quick Start build instructions to barretenberg README (#20951)
feat: batched chonk verification (#21083)
fix: link libc++ instead of libstdc++ for Rust FFI on Linux (#21203)
fix: [ECCVM] in the transcript table, no-ops force the next accumulator
to be 0. (#20849)
fix: resolve merge-train conflict with next (zig wrapper scripts + -g0)
(#21201)
fix: [ECCVM] rare edge case completeness issue when `z1 == 0` but `z2 !=
0` (#20858)
fix: use actual data extent for CommitmentKey in HypernovaDeciderProver
(#21206)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants