fix: [ECCVM] rare edge case completeness issue when z1 == 0 but z2 != 0 #20858
Merged
notnotraju merged 3 commits intomerge-train/barretenbergfrom Mar 6, 2026
Merged
Conversation
The transcript_input2 used a hardcoded `transcript_pc - 1` which assumed z1_zero = 0 whenever z2_zero = 0. This made the circuit unsatisfiable when z1_zero = 1 and z2_zero = 0. Replace with `transcript_pc - lookup_first` so the pc offset adapts correctly. Update gate count pinning values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
added 2 commits
March 6, 2026 13:17
…k/eccvm-external-audit-1-z1-zero-handling # Conflicts: # barretenberg/cpp/src/barretenberg/dsl/acir_format/gate_count_constants.hpp # barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp
- CHONK_RECURSION_GATES: 1685112 - ECCVM_RECURSIVE_VERIFIER_GATE_COUNT: 224707
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
BEGIN_COMMIT_OVERRIDE fix: add -g0 to zig presets to eliminate 11GB debug info bloat (#21071) fix: resolve flaky p2p_client test race condition on ARM64 (#21088) chore: remove domain iteration macros and address backing memory race (#20988) fix: [ECCVM] added domain separation for the multiset equality check. (#20352) feat: hybrid CRS hash verification — 8MB chunks, parallel, span-based (#21113) chore: unify splitting scalars interface (#20805) chore: add a unique id to each origin tag (#20924) chore: Native curve audit (#20936) chore: Update bootstrap in test vk haven't changed script (#21153) fix: use reduced form in WASM FromMontgomeryForm test (#21164) chore: erase ephemeral secrets from memory in schnorr and aes (#21106) chore: suppress clangd target triple version diagnostic (#21180) feat: Optimise new claim calculation (#21179) docs: add Quick Start build instructions to barretenberg README (#20951) feat: batched chonk verification (#21083) fix: link libc++ instead of libstdc++ for Rust FFI on Linux (#21203) fix: [ECCVM] in the transcript table, no-ops force the next accumulator to be 0. (#20849) fix: resolve merge-train conflict with next (zig wrapper scripts + -g0) (#21201) fix: [ECCVM] rare edge case completeness issue when `z1 == 0` but `z2 != 0` (#20858) fix: use actual data extent for CommitmentKey in HypernovaDeciderProver (#21206) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transcript_input2 used a hardcoded
transcript_pc - 1which assumed z1_zero = 0 whenever z2_zero = 0. This made the circuit unsatisfiable when z1_zero = 1 and z2_zero = 0. Replace withtranscript_pc - lookup_firstso the pc offset adapts correctly. Update gate count pinning values.