feat: add salt and secret params to env.deploy#21183
Merged
nventuro merged 3 commits intomerge-train/fairiesfrom Mar 5, 2026
Merged
feat: add salt and secret params to env.deploy#21183nventuro merged 3 commits intomerge-train/fairiesfrom
nventuro merged 3 commits intomerge-train/fairiesfrom
Conversation
…ariant The deploy oracle now accepts an explicit salt instead of the TXE hardcoding Fr.ONE. A new `deploy_opts` method on `TestEnvironment` accepts `DeployOptions` with optional salt and secret, and the existing `deploy` delegates to it using counter-based defaults for both. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add deployer parameter to the deploy oracle interface so the TXE no longer hardcodes AztecAddress.ZERO. Currently all callers pass zero, but the plumbing is in place for future configurability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mverzilli
approved these changes
Mar 5, 2026
noir-projects/aztec-nr/aztec/src/test/helpers/test_environment/test/deployment.nr
Outdated
Show resolved
Hide resolved
…/test/deployment.nr Co-authored-by: Martin Verzilli <martin@aztec-labs.com>
Collaborator
|
❌ Failed to cherry-pick to |
AztecBot
pushed a commit
that referenced
this pull request
Mar 5, 2026
Originally requested by @xorsal and @zkfrov. This simply adds a new `deploy_opts` function which takes `DeployOptions`, via which custom salt and secret can be speficied. In the future we might be able to allow specifying more things. The bigger change is that the deployment oraacle now supports salt, secret (and deployer, currently hardcoded), so we should not need to break this API in the near future. Closes #16656 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Martin Verzilli <martin@aztec-labs.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
BEGIN_COMMIT_OVERRIDE fix: empty undefined offchain messages for batch calls (#21157) feat: add aztecaddress::is_valid (#21072) feat: add ergonomic conversions for Noir's `Option<T>` (#21107) chore: use returns `true` for boolean fns (#21186) feat: add salt and secret params to env.deploy (#21183) END_COMMIT_OVERRIDE
Collaborator
|
❌ Failed to cherry-pick to |
AztecBot
added a commit
that referenced
this pull request
Mar 16, 2026
Backport of #21183 to v4-next. Adds DeployOptions struct with with_salt and with_secret methods for TestEnvironment. Updates TXE deploy oracle to accept salt and deployer params. Bumps ORACLE_VERSION from 16 to 17.
nventuro
pushed a commit
that referenced
this pull request
Mar 16, 2026
) ## Summary Backport of #21183 to v4-next. - Adds `DeployOptions` struct with `with_salt` and `with_secret` methods for `TestEnvironment` - Adds `deploy_opts` method to `TestEnvironment` for custom salt/secret deployment - Updates TXE deploy oracle to accept salt, deployer params and passes them through to contract instantiation - Bumps `ORACLE_VERSION` from 16 to 17 - Adds tests for deploy with custom salt/secret combinations ## Conflict Resolution Rebased onto latest `backport-to-v4-next-staging`. Conflicts were in: - `ORACLE_VERSION` files (16→17 bump) - `txe_oracles.nr` and `txe/index.ts` had oracle naming divergence (`aztec_txe_*` on v4-next vs `txe*` on the old branch) — applied only the salt/deployer parameter changes on top of the current v4-next naming. ## Original PR #21183 by @nventuro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally requested by @xorsal and @zkfrov.
This simply adds a new
deploy_optsfunction which takesDeployOptions, via which custom salt and secret can be speficied. In the future we might be able to allow specifying more things.The bigger change is that the deployment oraacle now supports salt, secret (and deployer, currently hardcoded), so we should not need to break this API in the near future.
Closes #16656