fix: use reduced form in WASM FromMontgomeryForm test#21164
Merged
kashbrti merged 1 commit intomerge-train/barretenbergfrom Mar 5, 2026
Merged
fix: use reduced form in WASM FromMontgomeryForm test#21164kashbrti merged 1 commit intomerge-train/barretenbergfrom
kashbrti merged 1 commit intomerge-train/barretenbergfrom
Conversation
kashbrti
approved these changes
Mar 5, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
BEGIN_COMMIT_OVERRIDE fix: add -g0 to zig presets to eliminate 11GB debug info bloat (#21071) fix: resolve flaky p2p_client test race condition on ARM64 (#21088) chore: remove domain iteration macros and address backing memory race (#20988) fix: [ECCVM] added domain separation for the multiset equality check. (#20352) feat: hybrid CRS hash verification — 8MB chunks, parallel, span-based (#21113) chore: unify splitting scalars interface (#20805) chore: add a unique id to each origin tag (#20924) chore: Native curve audit (#20936) chore: Update bootstrap in test vk haven't changed script (#21153) fix: use reduced form in WASM FromMontgomeryForm test (#21164) chore: erase ephemeral secrets from memory in schnorr and aes (#21106) chore: suppress clangd target triple version diagnostic (#21180) feat: Optimise new claim calculation (#21179) docs: add Quick Start build instructions to barretenberg README (#20951) feat: batched chonk verification (#21083) fix: link libc++ instead of libstdc++ for Rust FFI on Linux (#21203) fix: [ECCVM] in the transcript table, no-ops force the next accumulator to be 0. (#20849) fix: resolve merge-train conflict with next (zig wrapper scripts + -g0) (#21201) fix: [ECCVM] rare edge case completeness issue when `z1 == 0` but `z2 != 0` (#20858) fix: use actual data extent for CommitmentKey in HypernovaDeciderProver (#21206) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FromMontgomeryFormtest ingeneral_field.test.cpp(added by #20936) was comparing raw limbs afterfrom_montgomery_form(), expecting exactly{1, 0, 0, 0}. However, the WASM Montgomery multiplication returns coarse results in[0, 2p), sofrom_montgomery_form(one())can returnp+1instead of1— both represent the same field element, but the raw limbs differ.This caused
ecc_teststo fail in WASM builds (FieldTest/0.FromMontgomeryFormfor BN254 Fq andFieldTest/1.FromMontgomeryFormfor BN254 Fr), which dequeued merge-train/barretenberg PR #21084 from the merge queue.Fix: use
from_montgomery_form_reduced()for base fields to ensure full reduction to[0, p)before raw limb comparison. Extension fields already usefrom_montgomery_form_reduced()internally on their components, so they are unaffected.ClaudeBox log: http://ci.aztec-labs.com/5f9c459fdf9e2366-1