Skip to content

fix: [ECCVM] added domain separation for the multiset equality check.#20352

Merged
notnotraju merged 4 commits intomerge-train/barretenbergfrom
rk/eccvm-external-audit-1-set-domain-separation
Mar 4, 2026
Merged

fix: [ECCVM] added domain separation for the multiset equality check.#20352
notnotraju merged 4 commits intomerge-train/barretenbergfrom
rk/eccvm-external-audit-1-set-domain-separation

Conversation

@notnotraju
Copy link
Contributor

Added domain separation for the multiset equality check, as a matter of good hygiene.

@notnotraju notnotraju added ci-full Run all master checks. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure and removed ci-full Run all master checks. labels Feb 10, 2026
beta = beta_challenge;
beta_sqr = beta * beta;
beta_cube = beta_sqr * beta;
beta_quartic = beta_sqr * beta_sqr;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, eccvm stuff pollutes kernels

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right right

@notnotraju notnotraju force-pushed the rk/eccvm-external-audit-1-set-domain-separation branch from 33a3989 to f97decb Compare March 4, 2026 13:33
@notnotraju notnotraju merged commit ce2de2a into merge-train/barretenberg Mar 4, 2026
10 checks passed
@notnotraju notnotraju deleted the rk/eccvm-external-audit-1-set-domain-separation branch March 4, 2026 16:28
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2026
BEGIN_COMMIT_OVERRIDE
fix: add -g0 to zig presets to eliminate 11GB debug info bloat (#21071)
fix: resolve flaky p2p_client test race condition on ARM64 (#21088)
chore: remove domain iteration macros and address backing memory race
(#20988)
fix: [ECCVM] added domain separation for the multiset equality check.
(#20352)
feat: hybrid CRS hash verification — 8MB chunks, parallel, span-based
(#21113)
chore: unify splitting scalars interface (#20805)
chore: add a unique id to each origin tag (#20924)
chore: Native curve audit (#20936)
chore: Update bootstrap in test vk haven't changed script (#21153)
fix: use reduced form in WASM FromMontgomeryForm test (#21164)
chore: erase ephemeral secrets from memory in schnorr and aes (#21106)
chore: suppress clangd target triple version diagnostic (#21180)
feat: Optimise new claim calculation (#21179)
docs: add Quick Start build instructions to barretenberg README (#20951)
feat: batched chonk verification (#21083)
fix: link libc++ instead of libstdc++ for Rust FFI on Linux (#21203)
fix: [ECCVM] in the transcript table, no-ops force the next accumulator
to be 0. (#20849)
fix: resolve merge-train conflict with next (zig wrapper scripts + -g0)
(#21201)
fix: [ECCVM] rare edge case completeness issue when `z1 == 0` but `z2 !=
0` (#20858)
fix: use actual data extent for CommitmentKey in HypernovaDeciderProver
(#21206)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants