feat: batched chonk verification#21083
Merged
ledwards2225 merged 14 commits intomerge-train/barretenbergfrom Mar 5, 2026
Merged
feat: batched chonk verification#21083ledwards2225 merged 14 commits intomerge-train/barretenbergfrom
ledwards2225 merged 14 commits intomerge-train/barretenbergfrom
Conversation
Contributor
Author
|
All benchmarks run single-threaded Full Chonk Verification
IPA Verification Only (size 2^15)
Cost Breakdown (single proof, single-threaded)
|
notnotraju
reviewed
Mar 5, 2026
| @@ -115,6 +115,36 @@ bool ChonkAPI::verify([[maybe_unused]] const Flags& flags, | |||
| return response.valid; | |||
| } | |||
|
|
|||
Contributor
There was a problem hiding this comment.
For the use-case, I guess it is better that the batch size is not one of the arguments?
notnotraju
reviewed
Mar 5, 2026
| if (!result.all_checks_passed) { | ||
| return false; | ||
| } | ||
| ipa_claims.push_back(std::move(result.ipa_claim)); |
Contributor
There was a problem hiding this comment.
My clang-tidy claims Std::move of the expression of the trivially-copyable type 'OpeningClaimcurve::Grumpkin' has no effect
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
BEGIN_COMMIT_OVERRIDE fix: add -g0 to zig presets to eliminate 11GB debug info bloat (#21071) fix: resolve flaky p2p_client test race condition on ARM64 (#21088) chore: remove domain iteration macros and address backing memory race (#20988) fix: [ECCVM] added domain separation for the multiset equality check. (#20352) feat: hybrid CRS hash verification — 8MB chunks, parallel, span-based (#21113) chore: unify splitting scalars interface (#20805) chore: add a unique id to each origin tag (#20924) chore: Native curve audit (#20936) chore: Update bootstrap in test vk haven't changed script (#21153) fix: use reduced form in WASM FromMontgomeryForm test (#21164) chore: erase ephemeral secrets from memory in schnorr and aes (#21106) chore: suppress clangd target triple version diagnostic (#21180) feat: Optimise new claim calculation (#21179) docs: add Quick Start build instructions to barretenberg README (#20951) feat: batched chonk verification (#21083) fix: link libc++ instead of libstdc++ for Rust FFI on Linux (#21203) fix: [ECCVM] in the transcript table, no-ops force the next accumulator to be 0. (#20849) fix: resolve merge-train conflict with next (zig wrapper scripts + -g0) (#21201) fix: [ECCVM] rare edge case completeness issue when `z1 == 0` but `z2 != 0` (#20858) fix: use actual data extent for CommitmentKey in HypernovaDeciderProver (#21206) END_COMMIT_OVERRIDE
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
ChonkBatchVerifierfor batch verifying Chonk proofs.IPA::batch_reduce_verify()) (Note IPA is ~90% of verification time)bbapi::ChonkBatchVerify- ready to be integrated into the TSBatching is done by replacing$N$ single IPA verifier checks of the form:
$$C_0 = \langle a_0 \vec{s}, \vec{G} \rangle + a_0 b_0 u \cdot G$$ $\alpha$ chosen randomly by the verifier):
$$\sum_i \alpha^i C_{0,i} = \langle \sum_i \alpha^i a_{0,i} \vec{s_i}, \vec{G} \rangle + \left(\sum_i \alpha^i a_{0,i} b_{0,i} u_i\right) \cdot G$$
with a batched check of the form (with
See below for relevant benchmarks