fix: [ECCVM] in the transcript table, no-ops force the next accumulator to be 0.#20849
Merged
notnotraju merged 6 commits intomerge-train/barretenbergfrom Mar 6, 2026
Merged
Conversation
notnotraju
added
ci-no-fail-fast
notnotraju
force-pushed
the
rk/eccvm-external-audit-1-transcript-no-op
branch
from
974e406 to
f364d9b
Compare
suyash67
reviewed
Feb 26, 2026
| auto accumulator_infinity_q_reset = q_reset_accumulator * (-is_accumulator_empty_shift + 1); // degree 2 | ||
| auto accumulator_infinity_from_add = | ||
| any_add_is_active * (result_is_infinity - is_accumulator_empty_shift); // degree 3 | ||
| // When opcode_is_zero (no-op row), the accumulator output is forced to (0,0) by lines 428-429. |
Contributor
There was a problem hiding this comment.
nit: instead of referencing L428-429, describe the constraint you mean to refer. Line numbers will definitely get lost over time.
suyash67
approved these changes
Feb 26, 2026
Contributor
suyash67
left a comment
suyash67
left a comment
There was a problem hiding this comment.
Looks good. I'll suggest (if possible) adding a test or two to ensure the accumulator infinity behaviour is consistent
added 5 commits
March 5, 2026 16:26
…k/eccvm-external-audit-1-transcript-no-op # Conflicts: # barretenberg/cpp/src/barretenberg/dsl/acir_format/gate_count_constants.hpp
…k/eccvm-external-audit-1-transcript-no-op
…k/eccvm-external-audit-1-transcript-no-op
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
BEGIN_COMMIT_OVERRIDE fix: add -g0 to zig presets to eliminate 11GB debug info bloat (#21071) fix: resolve flaky p2p_client test race condition on ARM64 (#21088) chore: remove domain iteration macros and address backing memory race (#20988) fix: [ECCVM] added domain separation for the multiset equality check. (#20352) feat: hybrid CRS hash verification — 8MB chunks, parallel, span-based (#21113) chore: unify splitting scalars interface (#20805) chore: add a unique id to each origin tag (#20924) chore: Native curve audit (#20936) chore: Update bootstrap in test vk haven't changed script (#21153) fix: use reduced form in WASM FromMontgomeryForm test (#21164) chore: erase ephemeral secrets from memory in schnorr and aes (#21106) chore: suppress clangd target triple version diagnostic (#21180) feat: Optimise new claim calculation (#21179) docs: add Quick Start build instructions to barretenberg README (#20951) feat: batched chonk verification (#21083) fix: link libc++ instead of libstdc++ for Rust FFI on Linux (#21203) fix: [ECCVM] in the transcript table, no-ops force the next accumulator to be 0. (#20849) fix: resolve merge-train conflict with next (zig wrapper scripts + -g0) (#21201) fix: [ECCVM] rare edge case completeness issue when `z1 == 0` but `z2 != 0` (#20858) fix: use actual data extent for CommitmentKey in HypernovaDeciderProver (#21206) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new subrelations.