Skip to content

fix: use reduced form in WASM FromMontgomeryForm test #21164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kashbrti merged 1 commit into from
Mar 5, 2026
Merged

fix: use reduced form in WASM FromMontgomeryForm test #21164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion barretenberg/cpp/src/barretenberg/ecc/fields/general_field.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,17 @@ TYPED_TEST(FieldTest, FromMontgomeryForm)
using FF = TypeParam;

constexpr FF t0 = FF::one();
constexpr FF result = t0.from_montgomery_form();
// Use from_montgomery_form_reduced() for base fields to ensure full reduction to [0, p).
// The WASM Montgomery multiplication returns coarse results in [0, 2p), so without
// reduce_once() the raw limbs may hold p+1 instead of 1.
// Extension fields already call from_montgomery_form_reduced() on their components internally.
constexpr FF result = [&]() constexpr {
if constexpr (!IsExtensionField<FF>) {
return t0.from_montgomery_form_reduced();
} else {
return t0.from_montgomery_form();
}
}();
constexpr uint256_t expected = 0x01;
uint256_t to_be_compared;

Expand Down
Loading