Skip to content

fix: [ECCVM] rare edge case completeness issue when z1 == 0 but z2 != 0 #20858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notnotraju merged 3 commits into from
Mar 6, 2026
Merged

fix: [ECCVM] rare edge case completeness issue when z1 == 0 but z2 != 0 #20858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb16def
fix: correct z1_zero handling in ecc_set_relation transcript_input2
Feb 25, 2026
b825b40
Merge remote-tracking branch 'origin/merge-train/barretenberg' into r…
Mar 6, 2026
47ff544
Update gate count pinnings after merge
Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions barretenberg/cpp/src/barretenberg/dsl/acir_format/gate_count_constants.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ constexpr std::tuple<size_t, size_t> HONK_RECURSION_CONSTANTS(
// ========================================

// Gate count for Chonk recursive verification (Ultra with RollupIO)
inline constexpr size_t CHONK_RECURSION_GATES = 1685107;
inline constexpr size_t CHONK_RECURSION_GATES = 1685112;

// ========================================
// Hypernova Recursion Constants
Expand Down Expand Up @@ -147,7 +147,7 @@ inline constexpr size_t HIDING_KERNEL_ULTRA_OPS = 124;
// ========================================

// Gate count for ECCVM recursive verifier (Ultra-arithmetized)
inline constexpr size_t ECCVM_RECURSIVE_VERIFIER_GATE_COUNT = 224702;
inline constexpr size_t ECCVM_RECURSIVE_VERIFIER_GATE_COUNT = 224707;

// ========================================
// Goblin AVM Recursive Verifier Constants
Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ Accumulator ECCVMSetRelationImpl<FF>::compute_grand_product_denominator(const Al

auto transcript_input1 = transcript_pc + transcript_Px * beta + transcript_Py * beta_sqr + z1 * beta_cube +
second_term_tag; // degree = 1
auto transcript_input2 = (transcript_pc - 1) + transcript_Px * cube_root_unity * beta -
auto transcript_input2 = (transcript_pc - lookup_first) + transcript_Px * cube_root_unity * beta -
transcript_Py * beta_sqr + z2 * beta_cube + second_term_tag; // degree = 2

// The following diagram expresses a fingerprint of part of the tuple. It does not include `transcript_pc` and
Expand Down
Loading