Merged
Conversation
changelog: Internal, Automated Testing, Include components directory in stylesheet linting
* initial parameters * refactoring * inherit from button component * code review feedback * remove ref to light blue * Update app/components/login_button_component.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * refactoring for translation and cleaner code * build errors * add spanish and french text * Add changelog changelog: Upcoming Features, Lookbook Component, Login button component for dev docs (LG-11902) * fix spacing and hard code text for now * Update app/components/login_button_component.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Update app/components/login_button_component.scss Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Update spec/components/previews/login_button_component_preview.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * remove color subclass * Update app/components/login_button_component.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Update app/components/login_button_component.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Update app/components/login_button_component.html.erb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * inherit from base refactor * add tests --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* changelog: Internal, Doc Auth, Expand mock proofer to support selfie capture - used compact as a way to get around having a nil value when selfie isn't used. Unsure if that was the right method - adds tests for other failures - removes unneeded setup - adds testing for exact error keys - adds FaceResultMatch to the result_response - adds tests to result_response, only return selfie results if selfie performed - camel case the TrueID mock response Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Turn off encrypted_document_storage_enabled by default This just swaps in the prod values for the default values. Should be a no-op in production, where this setting is already explicitly disabled. [skip changelog] * Empty commit to poke Gitlab
#9904) * LG-11899: Remove unreliable operating system version from Chromium device names changelog: User-Facing Improvements, Device Name, Avoid misleading operating system version number in Chromium-based device names * Omit OS version from all device names See comments following conversations: - #9904 (comment) - https://gsa-tts.slack.com/archives/C01710KMYUB/p1704985300785019 * Update DeviceDecorator specs * Update more specs asserting OS version
* changelog: User-Facing improvements, Remove Voip configurations, remove unused voip configurations * remove block
* changelog: Internal, Specs, add new spec file to test multiple flag conditions * Update in_person_opt_in_ipp_spec.rb Nit picked and fixed. * minor updates * remove extraneous description in two tests
changelog: Internal, Database, Rename disposable_domains table to disposable_email_domains
It was empty in application.yml.default, and it doesn't appear in the s3 buckets for any env. [skip changelog]
* make glare/sharpness threshold constants match config values * changelog: Internal, DocAuth, refactor image quality thresholds for clarity * remove glare/sharpness threshold constants * fix tests that depended on frontend constants * change handling of possibly null thresholds
* Refactor logging configuration and setup changelog: Internal, Logging, Refactor logging configuration and setup * remove visit logging * Update config/application.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * remove reports_logger --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Update decorated_sp_session.selfie_required? to use FeatureManagement.idv_block_biometrics_requests? * Confirm selfie check was done if needed before leaving DocumentCapture or LinkSent Added document_capture_concern_spec and tested #confirm_selfie_performed_if_needed there changelog: Upcoming Features, Identity Verification selfie check, confirm selfie check has been performed before continuing from DocumentCapture * Fix document capture feature spec * Rename confirm_selfie_performed_if_needed to selfie_requirement_met? * Remove stray comments and use instance_doubles instead of plain doubles --------- Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: Eileen McFarland <eileen.mcfarland@gsa.gov> Co-authored-by: Brittany Greaner <brittany.greaner@gsa.gov>
changelog: Internal, In Person Flow Residential Address, allow viewing of non-FSM Address page.
changelog: Internal, Dependencies, Update New Relic
* Upgrade Node.js to latest LTS v20 changelog: Internal, Build Tooling, Upgrade Node.js to latest LTS v20 * Update .nvmrc * Fix spec global references to Event Our auto-globals only override if there isn't an equivalent global in Node default runtime. Seemingly, Node v20 added new "Event" and "CustomEvent" globals which conflict with expected unprefixed references within DOM code. * Update Brewfile * Update CI image SHA
* Fix accessibilty violation - header level Header under h1 has to be an h2, but it can be styled like an h3 Co-authored-by: Gina Yamada <gina.yamada@gsa.gov> * add h2 selector to pick up style * changelog: Upcoming Features, In-person proofing, Fix accessibility violation on the how to verify page * fix linter err * add regression test for accessibility --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
changelog: Internal, Reporting, Change Reuse Rate Percentage Calculation
If a user had an expired gpo code and requested a new letter more than the reminder timeframe ago, the user would not have been sent a reminder for the second letter. changelog: Bug Fixes, Verify By Mail, Send reminders to users who had an older letter. Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
zachmargolis
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features