Fixes a bug in the Verify By Mail reminder logic.#9916
Merged
Conversation
If a user had an expired gpo code and requested a new letter more than the reminder timeframe ago, the user would not have been sent a reminder for the second letter. changelog: Bug Fixes, Verify By Mail, Send reminders to users who had an older letter. Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
jmax-gsa
reviewed
Jan 12, 2024
|
|
||
| def send_emails(for_letters_sent_before) | ||
| letter_eligible_range = | ||
| reminder_eligible_range = |
| gpo_verification_pending_at: letter_eligible_range, | ||
| gpo_verification_pending_at: profile_eligible_range, | ||
| gpo_confirmation_codes: { reminder_sent_at: nil }, | ||
| deactivation_reason: [nil, :in_person_verification_pending], |
Contributor
There was a problem hiding this comment.
I thought this was here because a user might have a GPO letter for in-person proofing; is this not possible?
Contributor
Author
There was a problem hiding this comment.
Sonia confirmed that that flag is deprecated and no longer used.
soniaconnolly
approved these changes
Jan 12, 2024
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM. I saw spec fail on main and succeed on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12100
🛠 Summary of changes
If a user had an expired gpo code and requested a new letter more than the reminder timeframe ago, the user would not have been sent a reminder for the second letter.
📜 Testing Plan
You can run the newly added spec on main, then again on this branch.