LG-11882 (Step 2): Update code paths referencing DisposableDomain#9895
Merged
LG-11882 (Step 2): Update code paths referencing DisposableDomain#9895
Conversation
Base automatically changed from
aduth-lg-11882-add-disposable-email-domains
to
main
January 10, 2024 18:16
aduth
force-pushed
the
aduth-lg-11882-disposable-domains-code-path
branch
from
69d1156 to
721375e
Compare
changelog: Internal, Database, Rename disposable_domains table to disposable_email_domains
aduth
force-pushed
the
aduth-lg-11882-disposable-domains-code-path
branch
from
721375e to
fe27bd3
Compare
zachmargolis
approved these changes
Jan 10, 2024
Contributor
Author
|
#9894 is now settled in production and the data has been populated (see related Slack thread), so this is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11882
🛠 Summary of changes
Updates code paths referencing
DisposableDomainto referenceDisposableEmailDomaininstead, added in #9894.This will be followed-up with a pull request dropping the old table, to be merged in a separate deployment.
Do not merge: This should only be merged after #9894 is live in production.📜 Testing Plan
Verify tests pass referencing the new table:
rspec spec/controllers/sign_up/completions_controller_spec.rbRepeat testing plan from #9747 to verify no regressions in current logging.