LG-11695 DocumentCapture submit requires selfie check#9873
Merged
soniaconnolly merged 8 commits intomainfrom Jan 12, 2024
Merged
Conversation
…t.idv_block_biometrics_requests? Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
…e or LinkSent Added document_capture_concern_spec and tested #confirm_selfie_performed_if_needed there changelog: Upcoming Features, Identity Verification selfie check, confirm selfie check has been performed before continuing from DocumentCapture
soniaconnolly
requested review from
a team,
amirbey,
eileen-nava,
jmhooper and
night-jellyfish
and removed request for
a team
Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: Eileen McFarland <eileen.mcfarland@gsa.gov>
| def confirm_selfie_performed_if_needed | ||
| !decorated_sp_session.selfie_required? || stored_result.selfie_check_performed | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
@jmhooper Sonia and I tested this change and then also tested in main. We saw the expected behavior in both places (could not continue past the doc auth page without a selfie if the requirements were changed partway through). Do you have any advice on if there's something we're missing that's needed here? Or maybe these changes aren't needed?
(Putting the comment here so that the conversation can be chained / followed)
Contributor
Author
There was a problem hiding this comment.
Slack discussion here. The conclusion is that controller tests are sufficient for this.
jmhooper
reviewed
Jan 10, 2024
jmhooper
reviewed
Jan 10, 2024
jmhooper
reviewed
Jan 10, 2024
jmhooper
approved these changes
Jan 10, 2024
…nt-capture-submit-requires-selfie-check
Co-authored-by: Brittany Greaner <brittany.greaner@gsa.gov>
…nt-capture-submit-requires-selfie-check
soniaconnolly
deleted the
sonia-lg-11695-document-capture-submit-requires-selfie-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-11695
🛠 Summary of changes
This is for AC 3 of this ticket: DocumentCapture submit does not advance if a selfie check is not present and was requested
Previously, AC 1 was covered by #9846
confirm_selfie_check_performed_if_neededto DocumentCaptureConcern, which looks atdecorated_sp_sessionto see if the selfie check is required and looks at the stored result from TrueID to see if it was performedServiceProviderSession#selfie_required?to use the newFeatureManagement.idv_block_biometrics_requests?📜 Testing Plan
New behavior is confirmed by controller specs. The plan below confirms that selfie capture is still working as expected with these changes.
doc_auth_selfie_capture_enabled: trueDocumentCaptureControllerWelcomeController in new tab