LG-11885: Expand mock proofer to support selfie capture#9882
Merged
night-jellyfish merged 11 commits intomainfrom Jan 11, 2024
Merged
LG-11885: Expand mock proofer to support selfie capture#9882night-jellyfish merged 11 commits intomainfrom
night-jellyfish merged 11 commits intomainfrom
Conversation
night-jellyfish
commented
Jan 9, 2024
night-jellyfish
commented
Jan 9, 2024
Contributor
Author
There was a problem hiding this comment.
This seems to me the best place to test that if we're not checking the selfie, we don't have the portrait_match_results key, rather than building a whole new test for the negative condition. I thought making the opposite example of including the key above was then also warranted, and doing that changed the setup.
night-jellyfish
requested review from
a team and
dawei-nava
and removed request for
a team
dawei-nava
reviewed
Jan 9, 2024
zachmargolis
reviewed
Jan 9, 2024
night-jellyfish
force-pushed
the
brittany/lg-11885-mock-proofer-to-accept-selfie
branch
from
46dfc00 to
c04172c
Compare
dawei-nava
reviewed
Jan 10, 2024
- used compact as a way to get around having a nil value when selfie
isn't used. Unsure if that was the right method
Sending selfie_captured and face match value, rename needed
Testing fixes, updates
- adds tests for other failures
- removes unneeded setup
- adds testing for exact error keys
- adds face_result_match to the result_response
yml files
updates for yml and client
- create selfie yml files that have:
- passing doc auth
- `portrait_match_results` hash
- update client to return `portrait_match_results` hash
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
night-jellyfish
force-pushed
the
brittany/lg-11885-mock-proofer-to-accept-selfie
branch
from
b0335d5 to
4debbee
Compare
night-jellyfish
deleted the
brittany/lg-11885-mock-proofer-to-accept-selfie
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11885
🛠 Summary of changes
This change should allow you to use yml files with a
portrait_match_resultsentry to mock various states of selfie additions:📜 Testing Plan
doc_auth_selfie_capture_enabled: truein yourapplication.ymlbiometrics comparisonmake watch_eventsand look for theIdV: doc auth image upload vendor submittedin the following stepsface_match_resultpass / fail andface_error_messagein theIdV: doc auth image upload vendor submittedevent from themake watch_eventsstep