Skip to content

LG-11104: Remove VOIP configuration#9860

Merged
mdiarra3 merged 3 commits intomainfrom
LG-11104-voip-configurability-removed
Jan 11, 2024
Merged

LG-11104: Remove VOIP configuration#9860
mdiarra3 merged 3 commits intomainfrom
LG-11104-voip-configurability-removed

Conversation

@mdiarra3
Copy link
Contributor

@mdiarra3 mdiarra3 commented Jan 5, 2024

🎫 Ticket

Link to the relevant ticket:
LG-11104

🛠 Summary of changes

The VOIP configuration for voip block has been set to true for forever and no known forseeable change to that, and we dont seem to be using the voip allowed phones list either, so we can remove these configurations to always be on.

@mdiarra3 mdiarra3 requested a review from a team January 5, 2024 14:39
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We should also remove configurations from deployed environments to avoid warnings added in #9575. I see we configure this (redundantly, as true) in at least dev, int, staging, and prod.

@mdiarra3 mdiarra3 merged commit 40d5d4e into main Jan 11, 2024
@mdiarra3 mdiarra3 deleted the LG-11104-voip-configurability-removed branch January 11, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants