Upgrade Node.js to latest LTS v20#9876
Merged
mitchellhenke merged 5 commits intomainfrom Jan 12, 2024
Merged
Conversation
zachmargolis
approved these changes
Jan 9, 2024
Contributor
|
Node 20 is now available in all environments, so I am merging this |
changelog: Internal, Build Tooling, Upgrade Node.js to latest LTS v20
Our auto-globals only override if there isn't an equivalent global in Node default runtime. Seemingly, Node v20 added new "Event" and "CustomEvent" globals which conflict with expected unprefixed references within DOM code.
mitchellhenke
force-pushed
the
aduth-node-lts-20-2
branch
from
ea0b184 to
cf63944
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates Node.js to the latest LTS release (v20).
Do not merge: While this can technically be merged without issue, we want our development environment to match the production system, so this should wait to merge until those changes have been made.This continues from #9639, which could not be reopened.
📜 Testing Plan
Upgrade:
nvm install && nvm useVerify there aren't regressions in:
yarn testyarn buildmake runand spot-test the application