Merged
Conversation
* ft unlock support fix * ensure its valid * changelog: User-Facing Improvements, Authentication, Only show F/t Unlock when computer is eligible * fix spec * refactor to make method async * fix javascript test * fix schema * add public key credential supported in separate file * update platform auth available spec * Fix webauthn setup linting * make sure to wait for async to pass before confirming test * add hidden spec fix * fix capitalization
Add device name to email changelog: User-Facing Improvements, Authentication, Add device name to email
#9686) * Invalidate phone step at the beginning of create Since create starts a background process, invalidate any past successes while waiting for the new result. Also remove unused invalidate_steps_after_verify_info! and small spec cleanup changelog: User-facing Improvements, Identity verification phone step, clear previous success flag when repeating phone step * Add idv_session methods to mark phone step started, complete, and invalid
* update to rack 3 changelog: Internal, Dependencies, Upgrade to Rack 3 * fix spec * fix more specs * lowercase * do not return in map * update rack-cors * update rack-timeout and rack-proxy * use cache constant * use any? instead of eq(0) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* changelog: Bug fixes, In-Person Proofing, set enrollment date far away from DST in south america * Removing uneeded UTC
* Grabbing param value on success and merging in ab test analytics * changelog: Internal, In-Person Proofing, Update how to verify analytics to capture selected value, ab test buckets and other standard values * Update app/controllers/idv/how_to_verify_controller.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Add specs for how to verify selection analytics * Editing spec to take advantage of existing code --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* changelog: Bug Fixes, 2FA, Update backup code field label to be more consistent * changelog: Bug Fixes, 2FA, Update Enter your backup code page title * fix stray space in translated text * align backup code page title with h1 * utilize existing translated key value
* MKMR Account reuse report header month fixes changelog: Internal, Reporting, Fixes account reuse report header month * specs
changelog: Internal, Reporting, Update monthly key metrics report subject
…mail enter code screen (#9658) In addition to updating the call to `Pii::Cacher#fetch` in `EnterCodeController` to explicitly use the `gpo_pending_verification_profile` also did: * Controller specs for #index and #create actions that check for the correct profile id. * Lots of cleanup on the controller spec. In particular, it wasn't using the analytics mock properly (the tests were correct; they just did a _lot_ of extra work.) changelog: Internal,IdV,Part of Pii::Cacher update
* changelog: Internal, Local setup, Add jq to the brewfile
* PhoneErrorsController: add IdvStepConcern and allow back button changelog: User-facing Improvements, Identity verification phone step, allow back button on phone errors page * Add step_info and use confirm_step_allowed in PhoneErrorsController
changelog: Internal, Analytics, Add no-JavaScript tracking for Sign In page
* Add selfie box presence tests * Add tests for start/end of PassiveLiveness * Test that the selfie loading spinner shows correctly * Add test for document capture * Remove aria-label and revise tests to work without it * Fix lint problems * changelog: Internal, In-Person Proofing, Add tests for selfie feature * Fix spelling Co-authored-by: Brittany Greaner <35475380+night-jellyfish@users.noreply.github.com> * Remove duplicate comment Co-authored-by: Brittany Greaner <35475380+night-jellyfish@users.noreply.github.com> --------- Co-authored-by: Brittany Greaner <35475380+night-jellyfish@users.noreply.github.com>
* Update Rails changelog: Internal, Dependencies, Update Rails * use 7.1 defaults * more gem updates
* check to see if ipp is enabled * add testing for addtional logic * fix linter errors * update description of spec to be more specific * added specs to test additional logic * move step_info so it is the last public method * changelog: Upcoming Features, Opt-in IPP, added logic to skip Opt-in IPP if IPP is disabled * Clean up unused var, edit specs * updated description of specs
Will be used to track the level of identity verification attached to a profile (using a Rails enum). [skip changelog]
zachmargolis
approved these changes
Dec 5, 2023
mdiarra3
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
how to verifyanalytics to capture selected value, a/b test buckets and other standard values (#9679)jqto the brewfile (#9694)Upcoming Features