Skip to content

LG-11463 Add StepInfo for PhoneErrorsController#9687

Merged
soniaconnolly merged 3 commits intomainfrom
sonia-lg-11463-phone-errors
Dec 1, 2023
Merged

LG-11463 Add StepInfo for PhoneErrorsController#9687
soniaconnolly merged 3 commits intomainfrom
sonia-lg-11463-phone-errors

Conversation

@soniaconnolly
Copy link
Contributor

@soniaconnolly soniaconnolly commented Dec 1, 2023

🎫 Ticket

LG-11463

🛠 Summary of changes

Add StepInfo for PhoneErrorsController, and use :confirm_step_allowed before action. Jumping to to the failure page is still handled by the rate_limiting code, which is separate from FlowPolicy.

📜 Testing Plan

  • Create account, start IdV
  • Try to jump ahead to /verify/phone/errors/warning, expect to go back to current step
  • Try to jump ahead to /verify/phone/errors/jobfail, expect to go back to current step
  • Try to jump ahead to /verify/phone/errors/failure, expect to go back to current step
  • Fail the phone step with phone number 703-555-5555
  • Click back from the warning page, expect it to work
  • Return to phone step, resubmit 703-555-5555, expect to land on the warning
  • Type in /verify/enter_password, expect to land on phone step
  • Continue entering 703-555-5555 until you get rate-limited
  • Click back, expect to remain on /verify/phone/errors/failure page until going back to verify_info
  • Type in /verify/enter_password, expect to land on /verify/phone/errors/failure

changelog: User-facing Improvements, Identity verification phone step, allow back button on phone errors page
@soniaconnolly soniaconnolly requested review from a team and solipet December 1, 2023 00:21
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Ran through test plan with Sonia and works great.

@soniaconnolly soniaconnolly merged commit 2923e58 into main Dec 1, 2023
@soniaconnolly soniaconnolly deleted the sonia-lg-11463-phone-errors branch December 1, 2023 22:51
@solipet solipet mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants