LG-11463 Add StepInfo for PhoneErrorsController#9687
Merged
soniaconnolly merged 3 commits intomainfrom Dec 1, 2023
Merged
Conversation
changelog: User-facing Improvements, Identity verification phone step, allow back button on phone errors page
solipet
approved these changes
Dec 1, 2023
Contributor
solipet
left a comment
There was a problem hiding this comment.
LGTM - Ran through test plan with Sonia and works great.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11463
🛠 Summary of changes
Add StepInfo for PhoneErrorsController, and use :confirm_step_allowed before action. Jumping to to the failure page is still handled by the rate_limiting code, which is separate from FlowPolicy.
📜 Testing Plan