Skip to content

LG-11684 Opt-In IPP Should Respect the IPP Feature Flag#9680

Merged
gina-yamada merged 12 commits intomainfrom
yamada/LG-11684-Opt-in-Ipp-should-respect-Ipp-feature-flag
Dec 4, 2023
Merged

LG-11684 Opt-In IPP Should Respect the IPP Feature Flag#9680
gina-yamada merged 12 commits intomainfrom
yamada/LG-11684-Opt-in-Ipp-should-respect-Ipp-feature-flag

Conversation

@gina-yamada
Copy link
Contributor

@gina-yamada gina-yamada commented Nov 29, 2023

🎫 Ticket

LG-11684 Opt-in IPP should respect IPP feature flag

🛠 Summary of changes

When in_person_proofing_enabled is false, users should not be taken to the How to Verify page (and should be prevented from accessing it). We want to prevent a user from opting in to IPP.

  • Users should go directly from /verify/agreement to hybrid handoff /verify/hybrid_handoff
  • A user cannot visit the How to Verify page by typing /verify/how_to_verify in the address before (before or after this in the flow)

📜 Testing Plan

  • Step 1 Set in_person_proofing_enabled to false and in_person_proofing_opt_in_enabled to true in application.yml
  • Step 2 Create an account, and get started verifying your identify by going to /verify/welcome. Click continue.
  • Step 3 Secure your account by checking the radio button on /verify/agreement and clicking continue.
  • Step 4 Confirm the next url is /verify/hybrid_handoff. You should not be taken to /verify/how_to_verify.
  • Step 5 Confirm existing behavior is working as expected: Continue through the flow. Upload an image to fail proofing. You should never be taken to the IPP flow. You will be on /verify/document_capture and the page will read We couldn't verify your ID with a Try again button that takes you back to try uploading your images again.
  • Step 6 Start process over. Once you are on /verify/welcome, change the url to /verify/how_to_verify by typing in the address bar. Confirm you remain on the welcome page. Hit Continue.
  • Step 7 Once you are on /verify/agreement, change the url to /verify/how_to_verify by typing in the address bar. Confirm you remain on the agreement page. Check the box and hit Continue.
  • Step 8 Once you are on /verify/hybrid_handoff, change the url to /verify/how_to_verify by typing in the address bar. You should remain on the hybrid handoff page.
  • Step 9 Confirm you cannot land on the /verify/how_to_verify at all.

🎥 Recordings

Before | IPP is disabled & IPP Opt In Is Enabled
lg-11684.before.mov
After | IPP is disabled & IPP Opt In Is Enabled | Steps 1-5 of testing plan above
lg-11684.after.mov
After | IPP is disabled & IPP Opt In Is Enabled | Steps 6-9 of testing plan above
LG-11684-After-Cannot-hit-view.mov

@gina-yamada gina-yamada marked this pull request as ready for review November 30, 2023 17:01
Copy link
Contributor

@JackRyan1989 JackRyan1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, comprehensive testing. Good job! LGTM.

@gina-yamada gina-yamada merged commit 54ec315 into main Dec 4, 2023
@gina-yamada gina-yamada deleted the yamada/LG-11684-Opt-in-Ipp-should-respect-Ipp-feature-flag branch December 4, 2023 16:41
@solipet solipet mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants