LG-11684 Opt-In IPP Should Respect the IPP Feature Flag#9680
Merged
gina-yamada merged 12 commits intomainfrom Dec 4, 2023
Merged
LG-11684 Opt-In IPP Should Respect the IPP Feature Flag#9680gina-yamada merged 12 commits intomainfrom
gina-yamada merged 12 commits intomainfrom
Conversation
…IPP if IPP is disabled
…84-Opt-in-Ipp-should-respect-Ipp-feature-flag
…84-Opt-in-Ipp-should-respect-Ipp-feature-flag
JackRyan1989
approved these changes
Dec 1, 2023
Contributor
JackRyan1989
left a comment
There was a problem hiding this comment.
Good, comprehensive testing. Good job! LGTM.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11684 Opt-in IPP should respect IPP feature flag
🛠 Summary of changes
When in_person_proofing_enabled is false, users should not be taken to the How to Verify page (and should be prevented from accessing it). We want to prevent a user from opting in to IPP.
📜 Testing Plan
in_person_proofing_enabledto false andin_person_proofing_opt_in_enabledto true in application.yml/verify/agreementand clicking continue./verify/hybrid_handoff. You should not be taken to/verify/how_to_verify./verify/document_captureand the page will read We couldn't verify your ID with a Try again button that takes you back to try uploading your images again./verify/welcome, change the url to/verify/how_to_verifyby typing in the address bar. Confirm you remain on the welcome page. Hit Continue./verify/agreement, change the url to/verify/how_to_verifyby typing in the address bar. Confirm you remain on the agreement page. Check the box and hit Continue./verify/hybrid_handoff, change the url to/verify/how_to_verifyby typing in the address bar. You should remain on the hybrid handoff page./verify/how_to_verifyat all.🎥 Recordings
Before | IPP is disabled & IPP Opt In Is Enabled
lg-11684.before.mov
After | IPP is disabled & IPP Opt In Is Enabled | Steps 1-5 of testing plan above
lg-11684.after.mov
After | IPP is disabled & IPP Opt In Is Enabled | Steps 6-9 of testing plan above
LG-11684-After-Cannot-hit-view.mov