Jmax/lg 11550 read the correct pii from the session on the verify by mail enter code screen

[jmax-gsa]

🎫 Ticket

LG-11550

🛠 Summary of changes

Updated very by mail enter code controller to explicitly use PII from the gpo_verification_pending_profile.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Ensure that the new controller spec at the top of enter_code_controller_spec.rb passes without errors
• Ensure that all previous specs pass without errors.
• Add the debug line below to Pii::Cacher#fetch
• Create a user and go through requesting a verify by mail letter and return to your account page
• Using the Rails console, identify the user and their profile; make note of their respective IDs
• Go to the 'enter your code' page and enter the verify by mail code
• Inspect the Rails logs to verify that the correct profile ID was passed to Pii::Cacher#fetch

# DEBUG CODE
Rails.logger.debug "Pii::Cacher#fetch(#{profile_id.inspect})"

[JackRyan1989]

Is it possible to get to the code in this else statement if the rate_limiter is limited? Just wondering if the if !rate_limiter.limited? statement is necessary.

[jmax-gsa]

Yes, because the rate limiter may have been incremented during the form submission.

[JackRyan1989]

LGTM