LG 11479 enter backup code page title#9688
Conversation
kevinsmaster5
changed the title
| @@ -1,4 +1,4 @@ | |||
| <% self.title = t('titles.enter_2fa_code.security_code') %> | |||
| <% self.title = t('titles.enter_2fa_code.backup_code') %> | |||
There was a problem hiding this comment.
Maybe we can just reuse the same string as the heading and avoid duplicating it?
| <% self.title = t('titles.enter_2fa_code.backup_code') %> | |
| <% self.title = t('two_factor_authentication.backup_code_header_text') %> |
There was a problem hiding this comment.
True. I was thinking it had to be set from a titles: etc: etc: key but this way is is less of an overall code change.
There was a problem hiding this comment.
Yeah I could see an argument that it's nice to have all our titles in titles:, but I think this scenario has highlighted that it has a tendency to fall out of sync, and I think generally there shouldn't be many situations where the title is different from the main page H1.
| @@ -1,4 +1,4 @@ | |||
| <% self.title = t('titles.enter_2fa_code.security_code') %> | |||
There was a problem hiding this comment.
I was surprised this string isn't flagged as unused, but it looks like we use it for personal keys and TOTP in at least one place.
2 participants
🎫 Ticket
LG-11479
🛠 Summary of changes
Post-merge follow up to #9678
Updating page title accordingly to sync with change to form label.
📜 Testing Plan