Skip to content

LG-11463 idv_session methods for phone step started, complete, invalid#9686

Merged
soniaconnolly merged 3 commits intomainfrom
sonia-lg-11463-idv-session-methods-for-phone-complete
Dec 1, 2023
Merged

LG-11463 idv_session methods for phone step started, complete, invalid#9686
soniaconnolly merged 3 commits intomainfrom
sonia-lg-11463-idv-session-methods-for-phone-complete

Conversation

@soniaconnolly
Copy link
Contributor

@soniaconnolly soniaconnolly commented Nov 30, 2023

🎫 Ticket

LG-11463

🛠 Summary of changes

Add idv_session methods to mark phone step started (user passed lexis_nexis in phone_controller), mark it complete (user entered correct code in otp_verification_controller) and mark it invalid (user just submitted request for a code, starting background job to query lexis_nexis).

We mark the phone step invalid at the beginning of create to follow the same pattern as the verify_info_controllers. We clear prior attempts at the beginning, and then the background job marks the step complete when it succeeds.

📜 Testing Plan

  • Primarily specs, since this is refactoring
  • Create account, start IdV
  • Try to jump ahead to /verify/phone before submitting verify info, expect to remain on current page
  • Try to jump ahead to /verify/phone_confirmation before submitting verify info, expect to remain on current page
  • Try to jump ahead to /verify/phone_confirmation from phone page before clicking submit, expect to remain on phone page
  • Enter correct code, expect to proceed to enter password
  • Try clicking browser back button, expect to go back
  • Resubmit phone page and enter correct code, expect to proceed to enter password

Since create starts a background process, invalidate any past successes while waiting for the new result.

Also remove unused invalidate_steps_after_verify_info! and small spec cleanup

changelog: User-facing Improvements, Identity verification phone step, clear previous success flag when repeating phone step
@soniaconnolly soniaconnolly requested review from a team, matthinz and theabrad November 30, 2023 23:03
Copy link
Contributor

@matthinz matthinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soniaconnolly soniaconnolly merged commit deed786 into main Dec 1, 2023
@soniaconnolly soniaconnolly deleted the sonia-lg-11463-idv-session-methods-for-phone-complete branch December 1, 2023 00:08
@solipet solipet mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants