LG-11463 idv_session methods for phone step started, complete, invalid#9686
Merged
soniaconnolly merged 3 commits intomainfrom Dec 1, 2023
Merged
Conversation
Since create starts a background process, invalidate any past successes while waiting for the new result. Also remove unused invalidate_steps_after_verify_info! and small spec cleanup changelog: User-facing Improvements, Identity verification phone step, clear previous success flag when repeating phone step
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11463
🛠 Summary of changes
Add idv_session methods to mark phone step started (user passed lexis_nexis in phone_controller), mark it complete (user entered correct code in otp_verification_controller) and mark it invalid (user just submitted request for a code, starting background job to query lexis_nexis).
We mark the phone step invalid at the beginning of create to follow the same pattern as the verify_info_controllers. We clear prior attempts at the beginning, and then the background job marks the step complete when it succeeds.
📜 Testing Plan