Merged
Conversation
changelog: Internal, Code Quality, Remove feature flag associated with second MFA reminder
* Add account reactivation event logging changelog: Internal, Logging, Add account reactivation event logging * fix typo
changelog: Internal, Dependencies, Update dependencies to latest versions
* Upgrade SVGO to 3.x changelog: Internal, Dependencies, Update dependencies to latest version * Re-optimize assets * Enable type-checking for root JS files
* LG-11116 Refactor Report Building changelog: Internal, Reporting, Reorganize Individual Metric Reports Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Upgrade TypeScript to 5.2 changelog: Internal, Dependencies, Update dependencies to latest versions * Upgrade @typescript-eslint/parser
Follow-on to #9286, removing references to ial2_consent_given from the frontend. [skip changelog]
changelog: User-Facing Improvements, Reporting, Adding automated weekly authentication report job --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Failing spec for hybrid_flow barcode error (redo document capture) * Add the rest of a hybrid_mobile redo document capture spec (untested) * redo hybrid doc capture fixed * hybrid document capture controller determine reload of document * fix tests * LG-11012 changelog: Bug Fixes, Identity Verification, fix redo of hybrid document capture and barcode read error acceptance * resave document capture session * rename document capture session result created_at to captured_at * add captured_at attr to DocumentCaptureSessionResult in spec * confirm_ocr refactor * add tests for confirming hybrid document capture needed * unset redo_document_capture in idv_session during hybrid * unsets redo document capture in idv session with successful doc auth * ensure hybrid doc capture can occur after successful standard doc capture * test redo document hybrid after doc auth desktop * guard no longer needed * happy linting * remove unused store_doc_auth_result * move confirm_ocr to document capture session and call in standard flow * create doc cap session for doc cap controller spec * make sessio result private * create new session result for every doc auth response * fix init assignment * test that a new result is created when a doc auth is result is stored in doc cap session * happy linting * undo session_result changes * add test to verify failed images are retained in document capture session * remove unused variable assignment * Update app/controllers/idv/hybrid_mobile/document_capture_controller.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * happy linting * reset idv_sesson.redo_document capture in link_sent#update * test that pii pon verify _info is changesd upon redo_document_capture * fix text check * barcode attention if not redoing document capture * happy linting * add guard for document_capture_session requested at * remove unused new_session_result method * Update app/controllers/idv/document_capture_controller.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * add pii value checks to document capture orig on desktop and redo on mobile * guard incase barcode attention doc auth occurred before the release ad captured_at not yet stored in redis --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* Add secret scanning job changelog: Internal, Continuous Integration, Add secret scanning job * check all commits since target branch * Add SECRET_DETECTION_REPORT_FILE Per suggestion at: https://forum.gitlab.com/t/fail-the-pipeline-if-secret-detection-finds-vulnerabilities/56950/7 * Analyze secret_detection file to make job fail if there are vulnerabilities From: https://forum.gitlab.com/t/fail-the-pipeline-if-secret-detection-finds-vulnerabilities/56950/5 --------- Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
- "UnsupportedJurisdiction" means "we did not make a request to AAMVA because they don't support this jurisdiction" so they could not have charged us for that changelog: Internal, Reporting, Update billing logic for AAMVA * Bring back descriptive comment
* Update banner flag to optimized SVG matching USWDS changelog: User-Facing Improvements, Banner, Update flag image to match design system guidance * Trim whitespace
…AAL2 setup (#9304) * LG-11110: Allow user to reauthenticate with any MFA method changelog: Bug Fixes, MFA Setup, Fix issue preventing user from reauthenticating with an existing MFA method when adding a new method for strict AAL2 request * Sync spec descriptions to expected text * Add feature specs for SAML phishing required * Update options spec to enforce order See: https://github.com/18F/identity-idp/pull/9304/files#r1345773215 * Bump CodeClimate
Our KMS client now supports the use of multiple keys. Specifically it can be used for encryption with a single-region or multi-region key. This commit adds logging to the KMS tooling to give us visibility into which keys are being used in which contexts. [skip changelog]
mdiarra3
approved these changes
Oct 5, 2023
soniaconnolly
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal