Update banner flag to optimized SVG matching USWDS#9311
Merged
Conversation
changelog: User-Facing Improvements, Banner, Update flag image to match design system guidance
mitchellhenke
approved these changes
Oct 4, 2023
nickttng
approved these changes
Oct 4, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Replaces the flag image used for the banner component.
Why?
app/assetsaltogether, and use the file from the design system. Currently, USWDS only provides an unoptimized PNG file. I've proposed an upstream pull request to introduce both an optimized PNG and the vector image used here.us-flag.pngis smaller on disk (132 bytes), but larger overall download size from https://secure.login.gov/ (544 bytes). The SVG can be Brotli-compressed, unlike PNG (176 bytes brotli'd).📜 Testing Plan
Visually inspect the banner flag image.
👀 Screenshots