Merged
Conversation
[skip changelog]
n1zyy
added a commit
that referenced
this pull request
Oct 2, 2023
This builds on Luis's unmerged PR (#9299) and needs a test still. changelog: Internal, Reporting, Monthly report includes all-time user count
zachmargolis
reviewed
Oct 2, 2023
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
approved these changes
Oct 3, 2023
| csv_array << row | ||
| end | ||
| def upload_to_s3(report_body, report_name: nil) | ||
| _latest, path = generate_s3_paths(REPORT_NAME, 'csv', subname: report_name, now: report_date) |
Contributor
There was a problem hiding this comment.
so we're not using _latest here which means we're only writing the timestamped copy of the file, not the latest reference, is that intentional?
app/services/reporting/account_reuse_and_total_identities_report.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip changelog]