Skip to content

Upgrade TypeScript to 5.2#9307

Merged
aduth merged 2 commits intomainfrom
aduth-typescript-5-2
Oct 4, 2023
Merged

Upgrade TypeScript to 5.2#9307
aduth merged 2 commits intomainfrom
aduth-typescript-5-2

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Oct 3, 2023

🛠 Summary of changes

Upgrades TypeScript from 5.0.x to 5.2.x

Release notes:

Why?

  • Incorporate improvements outlined in release notes above (new features, optimizations)

The SubmissionComplete component was ported to TypeScript due to some issues flagged which appeared to be difficult / impossible to resolve in JavaScript syntax.

$ tsc
app/javascript/packages/document-capture/components/submission-complete.jsx:10:15 - error TS2304: Cannot find name 'T'.

10  * @prop {()=>T} read Resource reader.
                 ~

app/javascript/packages/document-capture/components/submission-complete.jsx:18:11 - error TS2315: Type 'Resource' is not generic.

18  * @prop {Resource<UploadSuccessResponse>} resource Resource object.
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

📜 Testing Plan

yarn typecheck

changelog: Internal, Dependencies, Update dependencies to latest versions
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit 35ccc55 into main Oct 4, 2023
@aduth aduth deleted the aduth-typescript-5-2 branch October 4, 2023 13:08
@jmhooper jmhooper mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants