Add account reactivation event logging#9301
Merged
mitchellhenke merged 2 commits intomainfrom Oct 3, 2023
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/add-reactivate-events
branch
from
b0fceb2 to
ef2bbe8
Compare
aduth
approved these changes
Oct 3, 2023
Contributor
There was a problem hiding this comment.
The thing that's confusing about this to me is that update is only called when the user clicks the button "I don't have my key", not when they click the other button that they have their personal key. I think ideally the submit event would capture both of these, but at least for investigative purposes, we do log the visit on the reactivation screen, which could be enough to see that a user progresses there.
Contributor
Author
There was a problem hiding this comment.
Yeah, I think the missing piece is the user not going to reactivation and skipping straight to idv
Contributor
|
Can we add test coverage? i.e. that an event is logged by the controller |
added 2 commits
October 3, 2023 10:01
changelog: Internal, Logging, Add account reactivation event logging
mitchellhenke
force-pushed
the
mitchellhenke/add-reactivate-events
branch
from
ef2bbe8 to
39e50df
Compare
mmagsa
approved these changes
Oct 3, 2023
Contributor
Author
Yep, done |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Based on discussion here, it should be much easier to understand patterns of identity verification when these events are present. This PR adds them.