Merged
Conversation
Goal is to match form field names to IdvSession properties. There will be 2 more PRs required here: 1. Actually change ial2_consent_given form field to idv_consent_given 2. Remove support for ial2_consent_given [skip changelog]
soniaconnolly
approved these changes
Sep 28, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
Yes please! I've had this on my list for a while. LGTM.
matthinz
changed the title
zachmargolis
approved these changes
Sep 28, 2023
|
|
||
| def submit(params) | ||
| @ial2_consent_given = params[:ial2_consent_given] == '1' | ||
| @idv_consent_given = params[:idv_consent_given] == '1' || params[:ial2_consent_given] == '1' |
Contributor
There was a problem hiding this comment.
Personally I'd go for one of these
Suggested change
| @idv_consent_given = params[:idv_consent_given] == '1' || params[:ial2_consent_given] == '1' | |
| @idv_consent_given = (params[:idv_consent_given] || params[:ial2_consent_given]) == '1' |
3 tasks
matthinz
added a commit
that referenced
this pull request
Oct 3, 2023
Follow-on to #9286, removing references to ial2_consent_given from the frontend. [skip changelog]
matthinz
added a commit
that referenced
this pull request
Oct 4, 2023
Follow-on to #9286, removing references to ial2_consent_given from the frontend. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on LG-11041 I noticed that, while we store the fact that the user checked the consent checkbox in IdvSession as
idv_consent_given, we are still usingial2_consent_givenfor the form fields. I'd like to get the naming consistent to help avoid confusion in the future.This PR renames some internal variables and allows using either
params[:idv_consent_given]orparams[ial2_consent_given]. There will be two subsequent PRs required after this one is deployed:ial2_consent_givenform field toidv_consent_givenial2_consent_givenentirely