Merged
Conversation
6718a09 to
cf2fb0a
Compare
zachmargolis
reviewed
Oct 2, 2023
zachmargolis
reviewed
Oct 2, 2023
Jeremy1026
reviewed
Oct 2, 2023
zachmargolis
reviewed
Oct 2, 2023
Jeremy1026
approved these changes
Oct 3, 2023
zachmargolis
approved these changes
Oct 3, 2023
…ly authentication report job
963af3d to
9164075
Compare
13ff7ba to
dfa4d27
Compare
zachmargolis
reviewed
Oct 4, 2023
zachmargolis
reviewed
Oct 4, 2023
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
zachmargolis
approved these changes
Oct 4, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-10040
🛠 Summary of changes
Reports::AuthenticationReportclass that pulls details from fromIdentityConfig.store.weekly_auth_funnel_report_configin order to create and email a weekly authentication funnel report for partners that opt-in.Reports::AuthenticationReportweekly. (note: should this be dropped until we are able to test it? Since it won't run without any objects in theweekly_auth_funnel_report_configit felt safe, but could also follow the pattern of https://cm-jira.usa.gov/browse/LG-10836 of not adding the job until we've tested it in production)Updated to make the email a little nicer in 13ff7ba
To test locally:
aws-vault exec prod-power -- bundle exec rails cReports::AuthenticationReport.new.perform(Time.zone.now)