Merged
Conversation
…it (#9153) * Add normalized email to user registration rate limit changelog: Internal, Registration, Use normalized email address for user registration rate limit
… from Your Account dashboard for desktop (#9246)
The idea here is we want to keep supporting any users who've bookmarked the GPO code page in anticipation of receiving their letter. I've added LG-11023 to track the eventual cleanup of these redirects. [skip changelog]
* changelog: Bug Fixes, MFA, removes Cancel option from Phone/Text screen * add a face or touch unlock check for cancel or return type footer link * simplify Choose another option * fix openid bug regression * make otp test more ubiquitous for other mfa not just ft unlock * adds in_multi_mfa_selection_flow to context * add test coverage for not-yet signed up * refactor to put Cancel logic in presenter * temporarily remove sign in test * adds test case for setup and phone access code validation redirect on cancel * fix missing click * moves account setup before mock_webauthn... * lint fix * remove unneeded statements * move add phone at setup spec to its own file * lint fix * added includes fix pinpoint-check * removes unneeded :data and includes from spec * move adding phone test to multiple_mfa_sign_up
* change position of disclaimer text * set `margin-top` * remove "mobile terms of use" only text * changelog: User-Facing Improvements, add phone setup, fix placement of disclaimers on phone screen * remove partial and `margin-top-0` utility class * restore feature flag * restore "Mobile Terms of Use"
* Build CI image changelog: Internal, Continuous Integration, Build CI image * use SHA * update sha
* LG-10912 Send Email of Key Metric report changelog: Internal, Reporting, Add Emailed Key Metrics Report Co-authored-by: Matt Wagner <mattwagner@navapbc.com>
changelog: Internal, Continuous Integration, Do not create CI image scan job when CI image is not built
* Cleanup: remove trailing spaces * Un-scale percents in monthly account reuse report **Why**: it's more conventional for percents to be between 0.0 and 1.0, and the tables report mailer expects them in this format changelog: Internal, Reporting, Fix percentage scaling in monthly account reuse report
* Bump phonelib from 0.8.3 to 0.8.4 Bumps [phonelib](https://github.com/daddyz/phonelib) from 0.8.3 to 0.8.4. - [Release notes](https://github.com/daddyz/phonelib/releases) - [Changelog](https://github.com/daddyz/phonelib/blob/master/CHANGELOG.md) - [Commits](daddyz/phonelib@v0.8.3...v0.8.4) --- updated-dependencies: - dependency-name: phonelib dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update specs to use new pretty-formatted Ireland numbers --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
* changelog: internal, in-person proofing usps enrollments, ensure parsing body covers html and text parts * changelog: internal, in-person proofing usps enrollments, correct a failing rebase * changelog: internal, ipp in-person proofing usps enrollments, correct lint and magical trailing spaces * changelog: internal, in-person proofing usps enrollments, add tests to cover all branches * changelog: internal, in-person proofing usps enrollments, lint fix because I always forget to check
* LG-1115: Email Addresses deletion bug fixes in user reinstate changelog: Internal, User suspension, Email Addresses deletion bug fixes in user reinstate * feedback * add YARD * Update spec/models/user_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
[skip changelog]
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.44 to 1.10.45. - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.44...v1.10.45) --- updated-dependencies: - dependency-name: libphonenumber-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Refactor WebAuthn public key algorithms changelog: Internal, Code Quality, Improve code readability of WebAuthn supported algorithms * Expand description/distinction of supported algorithms
aduth
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal