Skip to content

Build CI image#9231

Merged
mitchellhenke merged 3 commits intomainfrom
mitchellhenke/build-ci-image-here
Sep 26, 2023
Merged

Build CI image#9231
mitchellhenke merged 3 commits intomainfrom
mitchellhenke/build-ci-image-here

Conversation

@mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Sep 18, 2023

🛠 Summary of changes

This PR brings over the image build process for the CI image from https://github.com/18F/identity-devops.

@mitchellhenke mitchellhenke marked this pull request as ready for review September 25, 2023 15:41
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/build-ci-image-here branch 2 times, most recently from c85c64e to 298c884 Compare September 25, 2023 18:28
changelog: Internal, Continuous Integration, Build CI image
Mitchell Henke added 2 commits September 25, 2023 14:32
Copy link
Contributor

@timothy-spencer timothy-spencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that you technically need the ecr scanning stuff for CI/review_app images, but it's probably a good thing to have it visible so that you can scan through them and make sure they are fixed (if possible).

Approved! It will be good to have all this under the appdev team's control.

@mitchellhenke
Copy link
Contributor Author

I don't think that you technically need the ecr scanning stuff for CI/review_app images, but it's probably a good thing to have it visible so that you can scan through them and make sure they are fixed (if possible).

Approved! It will be good to have all this under the appdev team's control.

The ECR scanning for review apps already existed from @stephencshelton in #8781, my changes are turning it into a template to avoid repeating a bunch for scanning the CI image and the review app image

@mitchellhenke mitchellhenke merged commit 7cd1c2d into main Sep 26, 2023
@mitchellhenke mitchellhenke deleted the mitchellhenke/build-ci-image-here branch September 26, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants