LG-10693: Use normalized email address for user registration rate limit#9153
Merged
LG-10693: Use normalized email address for user registration rate limit#9153
Conversation
zachmargolis
reviewed
Sep 6, 2023
zachmargolis
reviewed
Sep 6, 2023
zachmargolis
reviewed
Sep 6, 2023
aduth
reviewed
Sep 6, 2023
zachmargolis
reviewed
Sep 6, 2023
zachmargolis
reviewed
Sep 6, 2023
jc-gsa
force-pushed
the
LG-10693-registration-rate-limit-normalized-email
branch
from
bf81a0b to
6a23828
Compare
Contributor
|
You'll need to rebase the branch or merge main to resolve the build failure (related Slack discussion). |
aduth
reviewed
Sep 11, 2023
Contributor
|
@jc-gsa Can you rebase the branch or merge main to get the build going? |
Contributor
|
Looks like there's a related failing spec. |
jc-gsa
force-pushed
the
LG-10693-registration-rate-limit-normalized-email
branch
from
d5f8e6d to
12b3491
Compare
Contributor
Author
This should be fixed. If any other tests surrounding rate limits are failing, they're likely off by one due to changes in implementation. As far as I can tell, the tests pass. The servers are down at the moment. And the test suite is unreliable on my machine. |
…email # Conflicts: # spec/features/visitors/sign_up_with_email_spec.rb
jc-gsa
deleted the
LG-10693-registration-rate-limit-normalized-email
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10693