LG-11115: Email Addresses deletion bug fixes in user reinstate#9269
Merged
olatifflexion merged 4 commits intomainfrom Sep 27, 2023
Merged
LG-11115: Email Addresses deletion bug fixes in user reinstate#9269olatifflexion merged 4 commits intomainfrom
olatifflexion merged 4 commits intomainfrom
Conversation
changelog: Internal, User suspension, Email Addresses deletion bug fixes in user reinstate
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
thanks for fixing! a few comments to clean things up
n1zyy
reviewed
Sep 27, 2023
n1zyy
approved these changes
Sep 27, 2023
zachmargolis
approved these changes
Sep 27, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM one last change to clean up. Thanks!
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why: deleting the SuspendedEmail row cascades and deletes its associated email addresses