Fix placement of disclaimers in new reCAPTCHA screen#9258
Conversation
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good to me! 👍
jmdembe
changed the title
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Minor comment about partial margins, but LGTM otherwise 👍
| <%= render 'shared/cancel_or_back_to_options' %> | ||
|
|
||
| <% if FeatureManagement.phone_recaptcha_enabled? %> | ||
| <%= render 'shared/recaptcha_disclosure' %> |
There was a problem hiding this comment.
With this no longer being at the bottom of the page, I think we could revisit the margins on the partial:
Specifically wondering if we could remove those utility classes, and rely on margins from the submit button (2.5rem bottom) and footer section (2rem top) instead.
I'm also not sure it makes a lot of sense to be a partial anymore as well, now that we have a single page for phone setups. We could inline it here.
There was a problem hiding this comment.
Definitely agree on removing the partial and moving the disclosure to be inline.
We can remove the margin-bottom-0 for the class with no adverse effect. The send code button does not naturally have margin on it, so we would still have to keep the margin-top-4
There was a problem hiding this comment.
The send code button does not naturally have margin on it, so we would still have to keep the
margin-top-4
Good point. I'd wonder if we'd want the margin on that instead. Doesn't make much of a difference either way. I'd expect the unit should probably change from 4 to 5 at least, for the standard vertical margins on primary buttons.
3 participants
🎫 Ticket
LG-10730
Link to Figma
🛠 Summary of changes
This PR moves the reCAPTCHA disclosure to be in a more intuitive location which is above the "Choose another method" link
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: