lg-10082 usps enrollment code email format#9259
Merged
racingspider merged 5 commits intomainfrom Sep 27, 2023
Merged
Conversation
aduth
reviewed
Sep 25, 2023
app/jobs/in_person/enrollments_ready_for_status_check/enrollment_pipeline.rb
Outdated
Show resolved
Hide resolved
app/jobs/in_person/enrollments_ready_for_status_check/enrollment_pipeline.rb
Outdated
Show resolved
Hide resolved
spec/jobs/in_person/enrollments_ready_for_status_check/enrollment_pipeline_spec.rb
Outdated
Show resolved
Hide resolved
internal, in-person proofing usps enrollments, ensure parsing body covers html and text parts
NavaTim
force-pushed
the
lg-10082_usps_mail_format
branch
from
81b3eb7 to
43d3343
Compare
internal, in-person proofing usps enrollments, correct a failing rebase
internal, ipp in-person proofing usps enrollments, correct lint and magical trailing spaces
gina-yamada
reviewed
Sep 26, 2023
internal, in-person proofing usps enrollments, add tests to cover all branches
internal, in-person proofing usps enrollments, lint fix because I always forget to check
gina-yamada
approved these changes
Sep 27, 2023
Contributor
gina-yamada
left a comment
gina-yamada
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding the analytic log tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10082
🛠 Summary of changes
Use either text_part or html_part to retrieve the enrollment code from USPS email and add an analytics event to determine in which part the code was found.