Merged
Conversation
There is no need to wait on building deployable artifacts. They will not be deployed if the test stage fails. If it passes, they will be ready to deploy. changelog: Internal, CI, Speed deployment by moving prepare_deploy earlier in CI
#8270) * LG-9429: Avoid sending new device notification before fully registered changelog: Bug Fixes, Account Creation, Avoid sending "New Sign-In" email when finishing registration on a second device * Remove temporary debugging code * Rename recent_devices? to has_devices? https://github.com/18F/identity-idp/pull/8270/files#r1176833065 * Flatten User#fully_registered with two_factor_enabled? * Update UserEventCreator specs reflecting fully registered * Revert to registration log as source for fully registered Previously moved away as suspected it may be unreliable for historical accounts, but it has been backfilled * let -> subject
…age (#8250) * create an account banner partial, refactor banner * change banner to not show on default * add config value, setup for view * toggle show based on page location * add test bucket and add analytic to user registration event * address PR comment, rename variable, fix logic * right wrongs that I had created changelog: Upcoming features, sign in, add create your account banner for A/B testing * add/edit analytics * remove urlhelper * revert changes made for account banner ab test * merge create an account banner w/ sign in a/b test * remove config value * lint fixes, cleanup for create account banner * modify header of create an account banner * make heading a banner instead * WIP: modify banner for a11y best practices * WIP: page title on sign in page * add banner variable to ab test * make adjustment to base c-a-b container * add test for banner test * remove binding, show banner after switching between languages * Address PR comment: make `@is_home_page` true * fix: 100 percent on default instead of banner * rename to `create_account_banner`
* update status * changelog: User-Facing Improvements, Authentication, Forgot Password url doesnt show password token * remove unneded schema * add spec on reset controller * reset password controller update * fix tests * update url * rubocop * rspec for new logic * rubocop * remove unneeded route * update application.yml * add test for both toggle on and off * update spec * refactor to move edit and storing session only on toggle * only delete on success or redirect * rspec and rubocop fixes
changelog: Internal, Code Quality, Clarify name for fully-registered test accounts
* LG-9334: Clean up Funnel::DocAuth::RegisterStep [skip changelog] Removes unused columns from the doc_auth_logs table: - send_link_view_at - send_link_view_count - email_sent_view_at - email_sent_view_count Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
* Add page titles, specs changelog: Bug Fixes, Authentication, Fix page titles on backup codes and webauthn setup pages
* Rename spec "javascripts" folder to align to app "javascript" changelog: Internal, Code Quality, Improve consistency of test folder naming * Updates references to spec/javascripts folder
* LG-9467 Stop using the proofing components for TMx fraud review store threatmetrix review status for user in idv session Co-authored-by: Jonathan Hooper <jmhooper@users.noreply.github.com> [skip changelog] * happy linting * Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain>
* LG-8319 Update IPP Barcode Communication changelog: User-Facing Improvements, IPP, Barcode Info Updates
* Updating sdk upgrade final steps changelog: Internal, Documentation, updating SDK upgrade documentation * Update docs/sdk-upgrade.md Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* changelog: Internal, Authentication, add additional analytics to for tracking a/b testing throughout mfa selection flow * rubocop * update phone setup controller * add rspecs to track analytics for bucket * fix rspec * fix spec * fix issue * rubocop
changelog: Internal, Redis Sessions, Remove configuration attributes for session key transition
* Remove fraud review pending and rejection fields changelog: Identity Verification, Internal, Remove unused fraud state fields * changelog: Internal, Identity Verification, Remove unused fraud state fields * Explicitly call boolean method not column * Target boolean method not column * Replace boolean assignment with timestamp * Replace column checks with boolean method check * Target boolean methods instead of timestamps * Use boolean matcher in specs * Match against equals
* Add before action to CaptureComplete to check that DocumentCapture completed successfully. * Test CaptureComplete before action in feature spec Check result before redirecting in DocumentCaptureController * Check success in standard flow DocumentCaptureController * Set async to false in hybrid flow feature specs We're not using async, and it causes failures due to missing data in DocumentCaptureControllers * Redirect to CaptureComplete if capture is complete changelog: Internal, Flow State Machine replacement, redirect as needed within document capture hybrid flow --------- Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
* Switch to using constants for auth_method values changelog: Internal, Maintenance, Switch to using constants for auth_method values * Move constants for auth methods into their own module Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/controllers/concerns/two_factor_authenticatable.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
approved these changes
May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features